JS binding for BigInt (#215)

* JS binding for BigInt

* fix

* clippy

Author: chenyan-dfinity

rust/candid/src/bindings/javascript.rs

@@ -229,7 +229,7 @@ pub mod value {
         use IDLValue::*;
         match &*v {
             Number(_) | Int(_) | Nat(_) | Int64(_) | Nat64(_) => {
-                RcDoc::text(format!("new BigNumber('{}')", v))
+                RcDoc::text(format!("BigInt({})", v))
             }
             Reserved => RcDoc::text("null"),
             Principal(id) => RcDoc::text(format!("Principal.fromText('{}')", id)),
@@ -290,7 +290,6 @@ pub mod test {
     pub fn test_generate(test: Test) -> String {
         let header = r#"// AUTO-GENERATED. DO NOT EDIT.
 // tslint:disable
-import BigNumber from 'bignumber.js';
 import * as IDL from './idl';
 import { Buffer } from 'buffer/';
 import { Principal } from './principal';

rust/candid/src/bindings/typescript.rs

@@ -9,16 +9,16 @@ fn pp_ty(ty: &Type) -> RcDoc {
     match *ty {
         Null => str("null"),
         Bool => str("boolean"),
-        Nat => str("BigNumber"),
-        Int => str("BigNumber"),
+        Nat => str("bigint"),
+        Int => str("bigint"),
         Nat8 => str("number"),
         Nat16 => str("number"),
         Nat32 => str("number"),
-        Nat64 => str("BigNumber"),
+        Nat64 => str("bigint"),
         Int8 => str("number"),
         Int16 => str("number"),
         Int32 => str("number"),
-        Int64 => str("BigNumber"),
+        Int64 => str("bigint"),
         Float32 => str("number"),
         Float64 => str("number"),
         Text => str("string"),
@@ -148,7 +148,6 @@ fn pp_actor<'a>(env: &'a TypeEnv, ty: &'a Type) -> RcDoc<'a> {
 
 pub fn compile(env: &TypeEnv, actor: &Option<Type>) -> String {
     let header = r#"import type { Principal } from '@dfinity/agent';
-import type BigNumber from 'bignumber.js';
 "#;
     let def_list: Vec<_> = env.0.iter().map(|pair| pair.0.as_ref()).collect();
     let defs = pp_defs(env, &def_list);

rust/candid/src/de.rs

@@ -351,7 +351,7 @@ impl<'de> Deserializer<'de> {
     // processed the field_name, field_name will be reset to None.
     fn set_field_name(&mut self, field: FieldLabel) {
         if self.field_name.is_some() {
-            panic!(format!("field_name already taken {:?}", self.field_name));
+            panic!("field_name already taken");
         }
         self.field_name = Some(field);
     }

rust/candid/src/lib.rs

@@ -246,6 +246,8 @@
 //! ```
 //!
 
+#![allow(clippy::upper_case_acronyms)]
+
 pub use candid_derive::{candid_method, export_service, CandidType};
 pub use serde::Deserialize;
 

rust/candid/tests/assets/ok/actor.d.ts

@@ -1,13 +1,12 @@
 import type { Principal } from '@dfinity/agent';
-import type BigNumber from 'bignumber.js';
 export type f = (
     arg_0: number,
   ) => Promise<number>;
 export type g = f;
 export type h = (arg_0: [Principal, string]) => Promise<[Principal, string]>;
 export type o = [] | [o];
 export default interface _SERVICE {
-  'f' : (arg_0: BigNumber) => Promise<[Principal, string]>,
+  'f' : (arg_0: bigint) => Promise<[Principal, string]>,
   'g' : f,
   'h' : g,
   'o' : (arg_0: o) => Promise<o>,

rust/candid/tests/assets/ok/class.d.ts

@@ -1,7 +1,6 @@
 import type { Principal } from '@dfinity/agent';
-import type BigNumber from 'bignumber.js';
 export type List = [] | [
-  [BigNumber, List]
+  [bigint, List]
 ];
 export default interface _SERVICE {
   'get' : () => Promise<List>,

rust/candid/tests/assets/ok/comment.d.ts

@@ -1,4 +1,3 @@
 import type { Principal } from '@dfinity/agent';
-import type BigNumber from 'bignumber.js';
 export type id = number;
 

rust/candid/tests/assets/ok/cyclic.d.ts

@@ -1,8 +1,5 @@
 import type { Principal } from '@dfinity/agent';
-import type BigNumber from 'bignumber.js';
-export type A = [] | [
-  B
-];
+export type A = [] | [B];
 export type B = [] | [C];
 export type C = A;
 export type X = Y;

rust/candid/tests/assets/ok/escape.d.ts

@@ -1,10 +1,9 @@
 import type { Principal } from '@dfinity/agent';
-import type BigNumber from 'bignumber.js';
 export interface t {
-  '\"' : BigNumber,
-  '\'' : BigNumber,
-  '\"\'' : BigNumber,
-  '\\\n\'\"' : BigNumber,
+  '\"' : bigint,
+  '\'' : bigint,
+  '\"\'' : bigint,
+  '\\\n\'\"' : bigint,
 };
 export default interface _SERVICE {
   '\n\'\"\'\'\"\"\r\t' : (arg_0: t) => Promise<undefined>,

rust/candid/tests/assets/ok/example.d.ts

@@ -1,24 +1,23 @@
 import type { Principal } from '@dfinity/agent';
-import type BigNumber from 'bignumber.js';
 export type List = [] | [
-  { 'head' : BigNumber, 'tail' : List }
+  { 'head' : bigint, 'tail' : List }
 ];
 export interface broker { 'find' : (arg_0: string) => Promise<Principal> };
 export type f = (arg_0: List, arg_1: [Principal, string]) => Promise<
     [] | [List]
   >;
 export type my_type = Principal;
 export interface nested {
-  _0_ : BigNumber,
-  _1_ : BigNumber,
-  _2_ : [BigNumber, BigNumber],
-  _3_ : { _0_ : BigNumber, _42_ : BigNumber, _43_ : number },
-  _40_ : BigNumber,
+  _0_ : bigint,
+  _1_ : bigint,
+  _2_ : [bigint, bigint],
+  _3_ : { _0_ : bigint, _42_ : bigint, _43_ : number },
+  _40_ : bigint,
   _41_ : { _42_ : null } |
     { 'A' : null } |
     { 'B' : null } |
     { 'C' : null },
-  _42_ : BigNumber,
+  _42_ : bigint,
 };
 export default interface _SERVICE {
   'f' : (arg_0: Array<number>, arg_1: [] | [boolean]) => Promise<undefined>,
@@ -27,12 +26,12 @@ export default interface _SERVICE {
       arg_1: List,
       arg_2: [] | [List],
       arg_3: nested,
-    ) => Promise<[BigNumber, Principal]>,
+    ) => Promise<[bigint, Principal]>,
   'h' : (
       arg_0: Array<[] | [string]>,
-      arg_1: { 'A' : BigNumber } |
+      arg_1: { 'A' : bigint } |
         { 'B' : [] | [string] },
       arg_2: [] | [List],
-    ) => Promise<{ _42_ : {}, 'id' : BigNumber }>,
+    ) => Promise<{ _42_ : {}, 'id' : bigint }>,
   'i' : f,
 };