handled the release not found case for app detail of external app (#5791)

Co-authored-by: Rajeev Ranjan<[email protected]>

Author: RajeevRanjan27

api/helm-app/HelmAppRestHandler.go

@@ -28,6 +28,7 @@ import (
 	clientErrors "github.com/devtron-labs/devtron/pkg/errors"
 	"github.com/devtron-labs/devtron/pkg/fluxApplication"
 	bean2 "github.com/devtron-labs/devtron/pkg/k8s/application/bean"
+	"github.com/devtron-labs/devtron/pkg/pipeline"
 	"net/http"
 	"strconv"
 	"strings"
@@ -144,6 +145,11 @@ func (handler *HelmAppRestHandlerImpl) GetApplicationDetail(w http.ResponseWrite
 	//RBAC enforcer Ends
 	appdetail, err := handler.helmAppService.GetApplicationDetail(context.Background(), appIdentifier)
 	if err != nil {
+
+		if pipeline.CheckAppReleaseNotExist(err) {
+			common.WriteJsonResp(w, err, nil, http.StatusNotFound)
+			return
+		}
 		apiError := clientErrors.ConvertToApiError(err)
 		if apiError != nil {
 			err = apiError

cmd/external-app/wire_gen.go

@@ -744,7 +744,7 @@ func (impl *AppDeploymentTypeChangeManagerImpl) fetchDeletedApp(ctx context.Cont
 			impl.logger.Errorw("error in getting application detail", "err", err, "deploymentAppName", pipeline.DeploymentAppName)
 		}
 
-		if err != nil && checkAppReleaseNotExist(err) {
+		if err != nil && CheckAppReleaseNotExist(err) {
 			successfulPipelines = impl.appendToDeploymentChangeStatusList(
 				successfulPipelines,
 				pipeline,

pkg/pipeline/AppDeploymentTypeChangeManager.go

@@ -284,7 +284,7 @@ type PipelineStrategy struct {
 	Default            bool                                   `json:"default"`
 }
 
-func checkAppReleaseNotExist(err error) bool {
+func CheckAppReleaseNotExist(err error) bool {
 	// RELEASE_NOT_EXIST check for helm App and NOT_FOUND check for argo app
 	return strings.Contains(err.Error(), bean.NOT_FOUND) || strings.Contains(err.Error(), bean.RELEASE_NOT_EXIST)
 }