Skip to content

Commit 9186fae

Browse files
Merge pull request #6497 from devtron-labs/chore-nil-implementation
chore: nil implementations fixed for user attribute in telemetry
2 parents 0e67f5b + f0e01b3 commit 9186fae

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

client/telemetry/TelemetryEventClient.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ func NewTelemetryEventClientImpl(logger *zap.SugaredLogger, client *http.Client,
9898
helmAppClient gRPC.HelmAppClient,
9999
cloudProviderIdentifierService cloudProviderIdentifier.ProviderIdentifierService, cronLogger *cron3.CronLoggerImpl,
100100
installedAppReadService installedAppReader.InstalledAppReadServiceEA,
101-
envVariables *util.EnvironmentVariables) (*TelemetryEventClientImpl, error) {
101+
envVariables *util.EnvironmentVariables,
102+
userAttributesRepository repository.UserAttributesRepository) (*TelemetryEventClientImpl, error) {
102103
cron := cron.New(
103104
cron.WithChain(cron.Recover(cronLogger)))
104105
cron.Start()
@@ -121,6 +122,7 @@ func NewTelemetryEventClientImpl(logger *zap.SugaredLogger, client *http.Client,
121122
cloudProviderIdentifierService: cloudProviderIdentifierService,
122123
telemetryConfig: TelemetryConfig{},
123124
globalEnvVariables: envVariables.GlobalEnvVariables,
125+
userAttributesRepository: userAttributesRepository,
124126
}
125127

126128
watcher.HeartbeatEventForTelemetry()

client/telemetry/TelemetryEventClientExtended.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func NewTelemetryEventClientImplExtended(logger *zap.SugaredLogger, client *http
8484
ciBuildConfigService pipeline.CiBuildConfigService, moduleRepository moduleRepo.ModuleRepository, serverDataStore *serverDataStore.ServerDataStore,
8585
helmAppClient client.HelmAppClient, installedAppReadService installedAppReader.InstalledAppReadService, userAttributesRepository repository.UserAttributesRepository,
8686
cloudProviderIdentifierService cloudProviderIdentifier.ProviderIdentifierService, cronLogger *cron3.CronLoggerImpl,
87-
gitOpsConfigReadService config.GitOpsConfigReadService) (*TelemetryEventClientImplExtended, error) {
87+
gitOpsConfigReadService config.GitOpsConfigReadService, envVariables *util.EnvironmentVariables) (*TelemetryEventClientImplExtended, error) {
8888

8989
cron := cron.New(
9090
cron.WithChain(cron.Recover(cronLogger)))
@@ -123,6 +123,7 @@ func NewTelemetryEventClientImplExtended(logger *zap.SugaredLogger, client *http
123123
userAttributesRepository: userAttributesRepository,
124124
cloudProviderIdentifierService: cloudProviderIdentifierService,
125125
telemetryConfig: TelemetryConfig{},
126+
globalEnvVariables: envVariables.GlobalEnvVariables,
126127
},
127128
}
128129

cmd/external-app/wire_gen.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wire_gen.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)