Skip to content

Commit 69d8e52

Browse files
committed
review changes
1 parent 17433c1 commit 69d8e52

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

internal/sql/repository/AppListingRepository.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
"github.com/devtron-labs/devtron/internal/middleware"
2828
appWorkflow2 "github.com/devtron-labs/devtron/internal/sql/repository/appWorkflow"
2929
"github.com/devtron-labs/devtron/internal/sql/repository/deploymentConfig"
30+
"github.com/devtron-labs/devtron/internal/util"
3031
repository2 "github.com/devtron-labs/devtron/pkg/cluster/repository"
3132
"go.opentelemetry.io/otel"
3233
"strings"
@@ -381,12 +382,16 @@ func (impl AppListingRepositoryImpl) deploymentDetailsByAppIdAndEnvId(ctx contex
381382

382383
deploymentDetail.EnvironmentId = envId
383384
dc, err := impl.deploymentConfigRepository.GetByAppIdAndEnvId(appId, envId)
384-
if err != nil {
385+
if err != nil && err != pg.ErrNoRows {
385386
impl.Logger.Errorw("error in getting deployment config by appId and envId", "appId", appId, "envId", envId, "err", err)
386387
return deploymentDetail, err
387388
}
388-
deploymentDetail.DeploymentAppType = dc.DeploymentAppType
389-
deploymentDetail.ReleaseMode = dc.ReleaseMode
389+
if err == pg.ErrNoRows {
390+
deploymentDetail.ReleaseMode = util.PIPELINE_RELEASE_MODE_CREATE
391+
} else {
392+
deploymentDetail.DeploymentAppType = dc.DeploymentAppType
393+
deploymentDetail.ReleaseMode = dc.ReleaseMode
394+
}
390395

391396
return deploymentDetail, nil
392397
}

0 commit comments

Comments
 (0)