feat: Docker pull env driven (#5767)

prakash100198 · web-flow · commit 5170040eafc6 · 2024-08-30T19:10:20.000+05:30
* useDockerApiToGetDigest menv driven flag to control pulling image either using docker pull or docker API

* UseAppDockerConfigForPrivateRegistries in workflow request

* revert

* revert
diff --git a/env_gen.md b/env_gen.md
@@ -259,6 +259,7 @@
  | USE_CASBIN_V2 | false |  | 
  | USE_CUSTOM_HTTP_TRANSPORT | false |  | 
  | USE_DEPLOYMENT_CONFIG_DATA | false |  | 
+ | USE_DOCKER_API_TO_GET_DIGEST | false |  | 
  | USE_EXTERNAL_NODE | false |  | 
  | USE_GIT_CLI | false |  | 
  | USE_IMAGE_TAG_FROM_GIT_PROVIDER_FOR_TAG_BASED_BUILD | false |  | 
diff --git a/pkg/pipeline/CiService.go b/pkg/pipeline/CiService.go
@@ -743,6 +743,7 @@ func (impl *CiServiceImpl) buildWfRequestForCiPipeline(pipeline *pipelineConfig.
 		PluginArtifactStage:         pluginArtifactStage,
 		ImageScanMaxRetries:         impl.config.ImageScanMaxRetries,
 		ImageScanRetryDelay:         impl.config.ImageScanRetryDelay,
+		UseDockerApiToGetDigest:     impl.config.UseDockerApiToGetDigest,
 	}
 	if pipeline.App.AppType == helper.Job {
 		workflowRequest.AppName = pipeline.App.DisplayName
diff --git a/pkg/pipeline/types/CiCdConfig.go b/pkg/pipeline/types/CiCdConfig.go
@@ -141,6 +141,7 @@ type CiCdConfig struct {
 	ExtBlobStorageSecretName                   string                       `env:"EXTERNAL_BLOB_STORAGE_SECRET_NAME" envDefault:"blob-storage-secret"`
 	UseArtifactListingQueryV2                  bool                         `env:"USE_ARTIFACT_LISTING_QUERY_V2" envDefault:"true"`
 	UseImageTagFromGitProviderForTagBasedBuild bool                         `env:"USE_IMAGE_TAG_FROM_GIT_PROVIDER_FOR_TAG_BASED_BUILD" envDefault:"false"` // this is being done for https://github.com/devtron-labs/devtron/issues/4263
+	UseDockerApiToGetDigest                    bool                         `env:"USE_DOCKER_API_TO_GET_DIGEST" envDefault:"false"`
 }
 
 type CiConfig struct {
diff --git a/pkg/pipeline/types/Workflow.go b/pkg/pipeline/types/Workflow.go
@@ -144,6 +144,7 @@ type WorkflowRequest struct {
 	Scope                       resourceQualifiers.Scope
 	BuildxCacheModeMin          bool `json:"buildxCacheModeMin"`
 	AsyncBuildxCacheExport      bool `json:"asyncBuildxCacheExport"`
+	UseDockerApiToGetDigest     bool `json:"useDockerApiToGetDigest"`
 }
 
 func (workflowRequest *WorkflowRequest) updateExternalRunMetadata() {

Original file line number	Diff line number	Diff line change
`@@ -743,6 +743,7 @@ func (impl CiServiceImpl) buildWfRequestForCiPipeline(pipeline pipelineConfig.`
`743`	`743`	`PluginArtifactStage: pluginArtifactStage,`
`744`	`744`	`ImageScanMaxRetries: impl.config.ImageScanMaxRetries,`
`745`	`745`	`ImageScanRetryDelay: impl.config.ImageScanRetryDelay,`
	`746`	`+ UseDockerApiToGetDigest: impl.config.UseDockerApiToGetDigest,`
`746`	`747`	`}`
`747`	`748`	`if pipeline.App.AppType == helper.Job {`
`748`	`749`	`workflowRequest.AppName = pipeline.App.DisplayName`
Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,7 @@ type CiCdConfig struct {`
`141`	`141`	ExtBlobStorageSecretName string `env:"EXTERNAL_BLOB_STORAGE_SECRET_NAME" envDefault:"blob-storage-secret"`
`142`	`142`	UseArtifactListingQueryV2 bool `env:"USE_ARTIFACT_LISTING_QUERY_V2" envDefault:"true"`
`143`	`143`	UseImageTagFromGitProviderForTagBasedBuild bool `env:"USE_IMAGE_TAG_FROM_GIT_PROVIDER_FOR_TAG_BASED_BUILD" envDefault:"false"` // this is being done for https://github.com/devtron-labs/devtron/issues/4263
	`144`	+ UseDockerApiToGetDigest bool `env:"USE_DOCKER_API_TO_GET_DIGEST" envDefault:"false"`
`144`	`145`	`}`
`145`	`146`
`146`	`147`	`type CiConfig struct {`
Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,7 @@ type WorkflowRequest struct {`
`144`	`144`	`Scope resourceQualifiers.Scope`
`145`	`145`	BuildxCacheModeMin bool `json:"buildxCacheModeMin"`
`146`	`146`	AsyncBuildxCacheExport bool `json:"asyncBuildxCacheExport"`
	`147`	+ UseDockerApiToGetDigest bool `json:"useDockerApiToGetDigest"`
`147`	`148`	`}`
`148`	`149`
`149`	`150`	`func (workflowRequest *WorkflowRequest) updateExternalRunMetadata() {`