Skip to content

Commit afa29a6

Browse files
veilvokayChristianHoffmannS2
authored andcommitted
feat(ui-library): 938 update component names (#968)
* feat(ui-library): #938 updated Button Text * feat(ui-library): #938 updated Button Icon * feat(ui-library): #938 updated Input Number * feat(ui-library): #938 updated Input Field Text * feat(ui-library): #939 changed Input Number -> Input Field Number * docs(general): #938 updated README.md with new component names * feat(ui-library): #938 resolved PR comments * feat(ui-library): #938 resolved PR comments * feat(ui-library): #938 small fix after rebase
1 parent 27926de commit afa29a6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+563
-564
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -262,15 +262,15 @@ To check that changes have applied do the following:
262262
#### Removing Icons
263263
Removing is slightly more difficult than adding, because there are multiple components which are using some of the icons by default. You can see the full list of these components below:
264264

265+
- Button Icon
266+
- Button Text
265267
- Checkbox
266268
- Form Caption
267269
- Icon
268-
- Icon Button
269-
- Number Input
270+
- Input Field Number
271+
- Input Field Text
270272
- Select
271273
- TabBar
272-
- Text Button
273-
- Text Input
274274
- Toggle Switch
275275

276276
> Note: If you use any of those components, make sure that you either haven't removed the icons they use from the project, or replaced missing icons with yours.

docs/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ Before creating a new issue, please [check if your issue already exists](https:/
7070
<li>Use the existing issue templates.</li>
7171
<li>It should be <i>specific</i>. It's important that it addresses one specific topic.</li>
7272
<li>If it is a bug it should be <i>reproducible</i>. It should contain all the instructions needed to reproduce the same outcome.</li>
73-
<li>If the issue is about a component, please add the component name to the beginning of issue title, followed by a dash and a more in detail description of the issue. For example: <code>Text Button - add new variant</code></li>
73+
<li>If the issue is about a component, please add the component name to the beginning of issue title, followed by a dash and a more in detail description of the issue. For example: <code>Button Text - add new variant</code></li>
7474
</ul>
7575
</details>
7676
After creating an issue, don’t forget to assign it to yourself. The core team will then check your issue to ensures that your idea fits the scope of the project and leave an approval comment. Waiting for approval makes it less likely to get a rejected pull request. We will do our best to reply to new issues within a week.

docs/PROJECTBACKGROUND.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This chapter provides the users with information about historical decisions, whe
1111
## Background
1212
The idea for a boilerplate design system formed in 2022 during a client project which included the creation of a new design system. The main goal was to find a way to reduce reduncancies when creating components. Lars Erbach and Marcel Doering teamed up and prepared an elevator pitch for the leadership. After this the leadership agreed to to invest some time for team to come up with a real business case and a final presentation until end of November 2022. For this Thorben Hartmann also joined the team. The resulting presentation can be found [here](https://www.figma.com/file/A3qtxWTli1tQpgIK9wAjBO/%F0%9F%8E%A8-B01LER-Pitch-Convolute-%5BTEMPLATES%5D-(Copy)?type=design&node-id=192%3A3244&mode=design&t=FiW9ptIXH0xYtE1x-1) (you need to be part of the Accenture org in Figma). The feedback was very overwhelmingly positive and the leadership directly made plans to allocate some budget for 2023 to build B01LER.
1313

14-
Early 2023 the budget to build B01LER was approved. Lars Töppner and Oliver Klee joined the team as developers and the team started with the setup. In early March, a first Milestone was reached with the finalization of the first component: the [Text Button](https://github.com/deven-org/boiler/issues/50). The team was on track to finish the initial set of components in the defined time, but unfortunatley Lars Töppner and a month later Oliver were needed on other projects and had to leave the team. Finding substitutes turned out to be harder than expected, before Christian Hoffman and David Kennedy took over the role of dev leads and brought back some stability to the team. To make up time that was lost during the staffing changes, the team size was extended and other developers and designers also joined the team, at one time reaching even 12 members.
14+
Early 2023 the budget to build B01LER was approved. Lars Töppner and Oliver Klee joined the team as developers and the team started with the setup. In early March, a first Milestone was reached with the finalization of the first component: the [Button Text](https://github.com/deven-org/boiler/issues/50). The team was on track to finish the initial set of components in the defined time, but unfortunatley Lars Töppner and a month later Oliver were needed on other projects and had to leave the team. Finding substitutes turned out to be harder than expected, before Christian Hoffman and David Kennedy took over the role of dev leads and brought back some stability to the team. To make up time that was lost during the staffing changes, the team size was extended and other developers and designers also joined the team, at one time reaching even 12 members.
1515

1616
In autumn 2023 another huge milestone was reached with the finalization of the initial set of [15 components](https://github.com/deven-org/boiler/milestone/1). It took a few more months though to finalise the first release, as some of the first components as well as some general topics needed some refactoring first. The first release went live on 16.12.2023 together with the B01LER website [boilerds.com](https://boilerds.com). Together with the first release, the repository and the Figma file were also published under open source licences (see also the milestones [Alpha Release](https://github.com/deven-org/boiler/milestone/15), [Release Figma File](https://github.com/deven-org/boiler/milestone/11) and [Make Repository Public](https://github.com/deven-org/boiler/milestone/12)).
1717

packages/figma-design-tokens/config/style-dictionary.config.cjs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,26 +13,27 @@ const semanticTypes = ['buttons', 'selectables', 'forms', 'global', 'ui'];
1313

1414
const componentTypes = [
1515
'ButtonGroup',
16+
'ButtonText',
17+
'ButtonIcon',
1618
'CaptionComponent',
1719
'CaptionGroup',
1820
'Checkbox',
1921
'Counter',
2022
'Divider',
2123
'FormLabel',
2224
'Icon',
23-
'IconButton',
2425
'IconDropdown',
2526
'InputIcon',
27+
'InputFieldNumber',
28+
'InputFieldText',
2629
'Loader',
2730
'RadioGroup',
28-
'NumberInput',
2931
'Select',
3032
'Slider',
3133
'StepperButton',
3234
'StepperCombo',
3335
'Radio',
3436
'TabBar',
35-
'TextButton',
3637
'TextArea',
3738
'ToggleSwitch',
3839
'Tooltip',

packages/figma-design-tokens/input/tokens/$themes.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2344,4 +2344,4 @@
23442344
},
23452345
"group": "Sizes"
23462346
}
2347-
]
2347+
]

packages/figma-design-tokens/input/tokens/cmp/sizeVariants.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
}
4545
}
4646
},
47-
"IconButton": {
47+
"ButtonIcon": {
4848
"Icon": {
4949
"SizeVariant": {
5050
"XS": {
@@ -190,7 +190,7 @@
190190
}
191191
}
192192
},
193-
"TextButton": {
193+
"ButtonText": {
194194
"Icon": {
195195
"SizeVariant": {
196196
"XS": {
@@ -276,4 +276,4 @@
276276
}
277277
}
278278
}
279-
}
279+
}

packages/figma-design-tokens/input/tokens/cmp/sizes.json

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -907,7 +907,7 @@
907907
}
908908
}
909909
},
910-
"IconButton": {
910+
"ButtonIcon": {
911911
"Container": {
912912
"Padding": {
913913
"XS": {
@@ -1317,7 +1317,7 @@
13171317
}
13181318
}
13191319
},
1320-
"NumberInput": {
1320+
"InputFieldNumber": {
13211321
"InputField": {
13221322
"TextWrapper": {
13231323
"ItemSpacing": {
@@ -2376,7 +2376,7 @@
23762376
}
23772377
}
23782378
},
2379-
"TextButton": {
2379+
"ButtonText": {
23802380
"Container": {
23812381
"Padding_V": {
23822382
"XS": {
@@ -2434,27 +2434,27 @@
24342434
},
24352435
"Padding": {
24362436
"XS": {
2437-
"value": "{cmp.TextButton.Container.Padding_V.XS} {cmp.TextButton.Container.Padding_H.XS}",
2437+
"value": "{cmp.ButtonText.Container.Padding_V.XS} {cmp.ButtonText.Container.Padding_H.XS}",
24382438
"type": "spacing",
24392439
"description": "Do not apply in Figma, use aliases instead."
24402440
},
24412441
"SM": {
2442-
"value": "{cmp.TextButton.Container.Padding_V.SM} {cmp.TextButton.Container.Padding_H.SM}",
2442+
"value": "{cmp.ButtonText.Container.Padding_V.SM} {cmp.ButtonText.Container.Padding_H.SM}",
24432443
"type": "spacing",
24442444
"description": "Do not apply in Figma, use aliases instead."
24452445
},
24462446
"MD": {
2447-
"value": "{cmp.TextButton.Container.Padding_V.MD} {cmp.TextButton.Container.Padding_H.MD}",
2447+
"value": "{cmp.ButtonText.Container.Padding_V.MD} {cmp.ButtonText.Container.Padding_H.MD}",
24482448
"type": "spacing",
24492449
"description": "Do not apply in Figma, use aliases instead."
24502450
},
24512451
"LG": {
2452-
"value": "{cmp.TextButton.Container.Padding_V.LG} {cmp.TextButton.Container.Padding_H.LG}",
2452+
"value": "{cmp.ButtonText.Container.Padding_V.LG} {cmp.ButtonText.Container.Padding_H.LG}",
24532453
"type": "spacing",
24542454
"description": "Do not apply in Figma, use aliases instead."
24552455
},
24562456
"XL": {
2457-
"value": "{cmp.TextButton.Container.Padding_V.XL} {cmp.TextButton.Container.Padding_H.XL}",
2457+
"value": "{cmp.ButtonText.Container.Padding_V.XL} {cmp.ButtonText.Container.Padding_H.XL}",
24582458
"type": "spacing",
24592459
"description": "Do not apply in Figma, use aliases instead."
24602460
}
@@ -2465,19 +2465,19 @@
24652465
"type": "spacing"
24662466
},
24672467
"SM": {
2468-
"value": "{cmp.TextButton.Container.ItemSpacing.XS}",
2468+
"value": "{cmp.ButtonText.Container.ItemSpacing.XS}",
24692469
"type": "spacing"
24702470
},
24712471
"MD": {
2472-
"value": "{cmp.TextButton.Container.ItemSpacing.XS}",
2472+
"value": "{cmp.ButtonText.Container.ItemSpacing.XS}",
24732473
"type": "spacing"
24742474
},
24752475
"LG": {
2476-
"value": "{cmp.TextButton.Container.ItemSpacing.XS}",
2476+
"value": "{cmp.ButtonText.Container.ItemSpacing.XS}",
24772477
"type": "spacing"
24782478
},
24792479
"XL": {
2480-
"value": "{cmp.TextButton.Container.ItemSpacing.XS}",
2480+
"value": "{cmp.ButtonText.Container.ItemSpacing.XS}",
24812481
"type": "spacing"
24822482
}
24832483
},
@@ -3209,4 +3209,4 @@
32093209
}
32103210
}
32113211
}
3212-
}
3212+
}

packages/js-example-app/src/index.ejs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,17 @@
1414
<div class="contentWrapper">
1515
<div class="componentWrapper">
1616
<div class="component">
17-
<p>Text Button</p>
18-
<blr-text-button
17+
<p>Button Text</p>
18+
<blr-button-text
1919
theme="Light"
2020
variant="cta"
2121
sizeVariant="md"
2222
label="Button"
2323
hasIcon="true"
2424
iconPosition="leading"
2525
icon="blr360"
26-
textButtonId="button-id"
27-
></blr-text-button>
26+
buttonTextId="button-id"
27+
></blr-button-text>
2828
<button id="toggleLoadingState">Toggle Loading State</button>
2929
<button id="toggleDisabledState">Toggle Disabled State</button>
3030
</div>
@@ -48,13 +48,13 @@
4848
</div>
4949

5050
<div class="component">
51-
<p>Text Input</p>
52-
<blr-text-input placeholder="Enter text..." value="" hintText="Hint"></blr-text-input>
51+
<p>Input Field Text</p>
52+
<blr-input-field-text placeholder="Enter text..." value="" hintText="Hint"></blr-input-field-text>
5353
</div>
5454

5555
<div class="component">
56-
<p>Number Input</p>
57-
<blr-number-input
56+
<p>Input Field Number</p>
57+
<blr-input-field-number
5858
value="1000"
5959
size="md"
6060
steppervariant="vertical"
@@ -67,12 +67,12 @@
6767
haslabel="true"
6868
label="Label-text"
6969
labelappendix="(Appendix)"
70-
numberinputid="test-id"
70+
inputfieldnumberid="test-id"
7171
theme="Light"
72-
name="NumberInput"
72+
name="InputFieldNumber"
7373
decimals="10"
7474
leadingzeros="3"
75-
></blr-number-input>
75+
></blr-input-field-number>
7676
</div>
7777

7878
<div class="component">
@@ -101,7 +101,7 @@
101101
offset="20"
102102
message="Message-text"
103103
>
104-
<blr-text-button theme="Light" variant="secondary" sizeVariant="md" label="Hover me"></blr-text-button>
104+
<blr-button-text theme="Light" variant="secondary" size="md" label="Hover me"></blr-button-text>
105105
</blr-tooltip>
106106
</div>
107107

packages/js-example-app/src/index.js

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ const toggleLoadingButton = document.querySelector('#toggleLoadingState');
55
const toggleDisabledState = document.querySelector('#toggleDisabledState');
66
const logsContainer = document.querySelector('#logs');
77

8-
const blrButton = document.getElementsByTagName('blr-text-button')[0];
8+
const blrButton = document.getElementsByTagName('blr-button-text')[0];
99
const blrCheckbox = document.getElementsByTagName('blr-checkbox')[0];
1010
const blrSelect = document.getElementsByTagName('blr-select')[0];
11-
const blrTextInput = document.getElementsByTagName('blr-text-input')[0];
11+
const blrInputFieldText = document.getElementsByTagName('blr-input-field-text')[0];
1212
const blrTextArea = document.getElementsByTagName('blr-textarea')[0];
1313

1414
const addLog = (log) => {
@@ -22,10 +22,10 @@ toggleLoadingButton.addEventListener('click', () => {
2222

2323
if (currentState) {
2424
blrButton.removeAttribute('loading');
25-
addLog('Set text button loading state to false');
25+
addLog('Set button text loading state to false');
2626
} else {
2727
blrButton.setAttribute('loading', 'true');
28-
addLog('Set text button loading state to true');
28+
addLog('Set button text loading state to true');
2929
}
3030
});
3131

@@ -34,23 +34,23 @@ toggleDisabledState.addEventListener('click', () => {
3434

3535
if (currentState) {
3636
blrButton.removeAttribute('disabled');
37-
addLog('Set text button disabled state to false');
37+
addLog('Set button text disabled state to false');
3838
} else {
3939
blrButton.setAttribute('disabled', 'true');
40-
addLog('Set text button loading state to true');
40+
addLog('Set button text loading state to true');
4141
}
4242
});
4343

4444
blrButton.addEventListener('blrClick', () => {
45-
addLog('blr-text-button clicked');
45+
addLog('blr-button-text clicked');
4646
});
4747

4848
blrButton.addEventListener('blrFocus', () => {
49-
addLog('blr-text-button focused');
49+
addLog('blr-button-text focused');
5050
});
5151

5252
blrButton.addEventListener('blrBlur', () => {
53-
addLog('blr-text-button blurred');
53+
addLog('blr-button-text blurred');
5454
});
5555

5656
blrCheckbox.addEventListener('blrCheckedChange', (e) => {
@@ -69,16 +69,16 @@ blrSelect.addEventListener('blrSelectedValueChange', () => {
6969
addLog('blr-select changed');
7070
});
7171

72-
blrTextInput.addEventListener('blrFocus', () => {
73-
addLog('blr-text-input focused');
72+
blrInputFieldText.addEventListener('blrFocus', () => {
73+
addLog('blr-input-field-text focused');
7474
});
7575

76-
blrTextInput.addEventListener('blrBlur', () => {
77-
addLog('blr-text-input blurred');
76+
blrInputFieldText.addEventListener('blrBlur', () => {
77+
addLog('blr-input-field-text blurred');
7878
});
7979

80-
blrTextInput.addEventListener('blrTextValueChange', () => {
81-
addLog('blr-text-input changed');
80+
blrInputFieldText.addEventListener('blrTextValueChange', () => {
81+
addLog('blr-input-field-text changed');
8282
});
8383

8484
blrTextArea.addEventListener('blrFocus', () => {

packages/ui-library/src/components/button-group/index.stories.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
import { html } from 'lit';
33
import '../../index';
44
import { ButtonGroupSizes, ButtonGroupAlignmentVariants } from '../../globals/constants';
5-
import { BlrIconButtonRenderFunction } from '../icon-button/renderFunction';
6-
import { BlrTextButtonRenderFunction } from '../text-button/renderFunction';
5+
import { BlrButtonIconRenderFunction } from '../button-icon/renderFunction';
6+
import { BlrButtonTextRenderFunction } from '../button-text/renderFunction';
77
import { BlrButtonGroupType } from '.';
88
import { BlrButtonGroupRenderFunction } from './renderFunction';
99

@@ -57,7 +57,7 @@ export default {
5757
docs: {
5858
description: {
5959
component: `<markdown>
60-
Button Group allows users to select one option from the group. They are visually cohesive, meaning they share a similar appearance in terms of size, style, and often color. This consistency helps users quickly identify that these buttons are related. The Button Group component utilizes the slot element, rendering multiple Text Button or Icon Button components, or the combination of both. For more information have a look at the [Text Button](?path=/docs/design-system-web-components-actions-buttons-text-button--docs) and the [Icon Button](?path=/docs/design-system-web-components-actions-buttons-icon-button--docs) components.
60+
Button Group allows users to select one option from the group. They are visually cohesive, meaning they share a similar appearance in terms of size, style, and often color. This consistency helps users quickly identify that these buttons are related. The Button Group component utilizes the slot element, rendering multiple Button Text or Button Icon components, or the combination of both. For more information have a look at the [Button Text](?path=/docs/components-button-text--docs) and the [Button Icon](?path=/docs/components-button-icon--docs) components.
6161
- [**Appearance**](#appearance)
6262
- [**Alignment**](#alignment)
6363
</markdown>
@@ -74,27 +74,27 @@ export default {
7474

7575
export const ButtonGroup = (
7676
params: BlrButtonGroupType,
77-
primaryLabel: string = 'Text Button',
78-
secondaryLabel: string = 'Text Button'
77+
primaryLabel: string = 'Button Text',
78+
secondaryLabel: string = 'Button Text'
7979
) => {
8080
const contentButtons = html`
81-
${BlrTextButtonRenderFunction({
82-
label: typeof primaryLabel === 'string' ? primaryLabel : 'Text Button',
81+
${BlrButtonTextRenderFunction({
82+
label: typeof primaryLabel === 'string' ? primaryLabel : 'Button Text',
8383
theme: 'Light',
8484
loading: false,
8585
variant: 'primary',
8686
disabled: false,
8787
buttonDisplay: 'inline-block',
8888
})}
89-
${BlrTextButtonRenderFunction({
89+
${BlrButtonTextRenderFunction({
9090
label: secondaryLabel,
9191
theme: 'Light',
9292
loading: false,
9393
variant: 'secondary',
9494
disabled: false,
9595
buttonDisplay: 'inline-block',
9696
})}
97-
${BlrIconButtonRenderFunction({
97+
${BlrButtonIconRenderFunction({
9898
theme: 'Light',
9999
loading: false,
100100
variant: 'silent',

0 commit comments

Comments
 (0)