Merge branch '3.8.x' into 4.0.x

* 3.8.x:
  Keep NVARCHAR(MAX) length as -1 (doctrine#6251)

Author: derrabus

src/Schema/SQLServerSchemaManager.php

@@ -83,12 +83,20 @@ protected function _getPortableTableColumnDefinition(array $tableColumn): Column
 
         switch ($dbType) {
             case 'nchar':
-            case 'nvarchar':
             case 'ntext':
                 // Unicode data requires 2 bytes per character
                 $length /= 2;
                 break;
 
+            case 'nvarchar':
+                if ($length === -1) {
+                    break;
+                }
+
+                // Unicode data requires 2 bytes per character
+                $length /= 2;
+                break;
+
             case 'varchar':
                 // TEXT type is returned as VARCHAR(MAX) with a length of -1
                 if ($length === -1) {

tests/Functional/Schema/SQLServerSchemaManagerTest.php

@@ -129,4 +129,19 @@ public function testPkOrdering(): void
 
         self::assertSame(['colB', 'colA'], $firstIndex->getColumns());
     }
+
+    public function testNvarcharMaxIsLengthMinus1(): void
+    {
+        $sql = 'CREATE TABLE test_nvarchar_max (
+            col_nvarchar_max NVARCHAR(MAX),
+            col_nvarchar NVARCHAR(128)
+        )';
+
+        $this->connection->executeStatement($sql);
+
+        $table = $this->schemaManager->introspectTable('test_nvarchar_max');
+
+        self::assertSame(-1, $table->getColumn('col_nvarchar_max')->getLength());
+        self::assertSame(128, $table->getColumn('col_nvarchar')->getLength());
+    }
 }