-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Document default value for Maven plugin parameter "dataDirectory" #7434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If you are planning a caching strategy - you can just configure the directory and then you know what the value is. But yes, I understand we need to document the default value. Which is:
|
The problem is the default value could change in the future. So it is better if you specify a value if you are going to implement caching... alternatively - cache |
If it is within the m2 repo, one doesn't need a dedicated caching strategy, e.g. the one for https://github.com/actions/setup-java#caching-packages-dependencies should suffice, isn't it? |
It should be sufficient. |
The way I deal with is just to use the dependency-check version in the data location. That is too conservative, obviously, but it always works. Even better than documentation of the schema version, if there were a either a machine-readable resource or command that told you the schema version, that would be useful for not only a local data cache, but also for a scheme where a site could run multiple DB-server based mirrors for the different version, so that all the site's users of dependency-check did not have to the update in lockstep. For example, the DB server could have different database names appended with the schema version – the site manager would still have to arrange for the various database to be updated independently, and would need to make a decision about when to drop the databases that supported the older versions. Yet another approach is for the client to specifically the parent directory for data, and then let dependency-check use a subdirectory of its own choosing for the schema dependent data (i.e., database). |
It is already documented, see https://jeremylong.github.io/DependencyCheck/dependency-check-maven/configuration.html#Advanced_Configuration → dataDirectory (documented value doesn't include the version, though) |
Currently the page at https://jeremylong.github.io/DependencyCheck/dependency-check-maven/check-mojo.html#dataDirectory does not expose which directory is used by default if no explicit value is configured. This would be beneficial to document in either the javadoc or via the
default
field of the@Parameter
annotation (https://maven.apache.org/plugin-tools/maven-plugin-annotations/apidocs/org/apache/maven/plugins/annotations/Parameter.html#defaultValue--), which also ends up in the generated documentation.The text was updated successfully, but these errors were encountered: