Skip to content

Commit dba4678

Browse files
committed
[TASK] Remove the custom close event because the native HTML dialog element has its own close event
1 parent 98e41b5 commit dba4678

File tree

6 files changed

+3
-24
lines changed

6 files changed

+3
-24
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ The following events are available:
300300
| `close` | Triggered after Parvus has been closed |
301301
| `destroy` | Triggered after Parvus has been destroyed |
302302

303-
Except for the `destroy` event, you can access the current source element using the `event.detail.source` property.
303+
Except for the `close` and `destroy` events, you can access the current source element using the `event.detail.source` property.
304304

305305
```js
306306
prvs.on('open', function (event) {

dist/js/parvus.esm.js

-7
Original file line numberDiff line numberDiff line change
@@ -523,13 +523,6 @@ function Parvus(userOptions) {
523523
IMAGE.addEventListener('transitionend', transitionendHandler, {
524524
once: true
525525
});
526-
527-
// Create and dispatch a new event
528-
fire('close', {
529-
detail: {
530-
source: GROUPS[activeGroup].triggerElements[currentIndex]
531-
}
532-
});
533526
};
534527

535528
/**

dist/js/parvus.esm.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/parvus.js

-7
Original file line numberDiff line numberDiff line change
@@ -529,13 +529,6 @@
529529
IMAGE.addEventListener('transitionend', transitionendHandler, {
530530
once: true
531531
});
532-
533-
// Create and dispatch a new event
534-
fire('close', {
535-
detail: {
536-
source: GROUPS[activeGroup].triggerElements[currentIndex]
537-
}
538-
});
539532
};
540533

541534
/**

dist/js/parvus.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/js/parvus.js

-7
Original file line numberDiff line numberDiff line change
@@ -519,13 +519,6 @@ export default function Parvus (userOptions) {
519519
}
520520

521521
IMAGE.addEventListener('transitionend', transitionendHandler, { once: true })
522-
523-
// Create and dispatch a new event
524-
fire('close', {
525-
detail: {
526-
source: GROUPS[activeGroup].triggerElements[currentIndex]
527-
}
528-
})
529522
}
530523

531524
/**

0 commit comments

Comments
 (0)