Skip to content

compat: child_process.execFileSync #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kt3k opened this issue Mar 8, 2022 · 5 comments
Closed

compat: child_process.execFileSync #2011

kt3k opened this issue Mar 8, 2022 · 5 comments
Assignees
@cjihrig

Comments

@kt3k
Copy link
Member

kt3k commented Mar 8, 2022

part of denoland/deno#18326

We need to shim child_process.execFileSync to esbuild and remix run with node compat mode.
@kt3k
Copy link
Member Author

kt3k commented Mar 8, 2022

Does it make sense to add outputSync method to Child class of two-tier subprocess API? https://github.com/denoland/deno/pull/11618/files#diff-50535d25bde221d79f9204917ea7cd78b3ceb55283838a89aa8e04a3a29d0b7aR1171

@crowlKats
Copy link
Member

Yea, I think that would be the best way to achieve this. Should be fairly simple to add as well

@bartlomieju
Copy link
Member

Yea, I think that would be the best way to achieve this. Should be fairly simple to add as well

How so? I think we will need a completely separate implementation that uses sync API from std instead of using tokio.

@iuioiua
Copy link
Contributor

iuioiua commented Sep 26, 2022

execSync has been implemented in #2689.

@cjihrig cjihrig self-assigned this Sep 26, 2022
@cjihrig
Copy link
Contributor

cjihrig commented Oct 20, 2022

Closing this, as the API was added in #2699.

@cjihrig cjihrig closed this as completed Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjihrig cjihrig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kt3k @cjihrig @crowlKats @bartlomieju @iuioiua