Skip to content

cli/tests/tty_tests (aka tools/complex_permissions_test.py and tools/permissions_test.py) was disabled and should be re-enabled #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ry opened this issue Oct 15, 2019 · 0 comments · Fixed by #4200
Closed

cli/tests/tty_tests (aka tools/complex_permissions_test.py and tools/permissions_test.py) was disabled and should be re-enabled #3129

ry opened this issue Oct 15, 2019 · 0 comments · Fixed by #4200

Comments

@ry
Copy link
Member

ry commented Oct 15, 2019 •
edited
Loading

ddbfe9b

Ideally they would be re-written to use ptty facilities in Rust rather than python.

Another problem I have: I don't think permissions should be tested by interacting with a ptty. I think if we implemented #2767, then we wouldn't need such complex tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ry @bartlomieju