Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/canvas): handle integer overflow in createImageBitmap #28764

Merged
merged 2 commits into from
Apr 10, 2025
Merged

fix(ext/canvas): handle integer overflow in createImageBitmap #28764

merged 2 commits into from
Apr 10, 2025

Conversation

Hajime-san
Copy link
Contributor

fixes #28732

littledivy
littledivy approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 1513550 into denoland:main Apr 10, 2025
18 checks passed
@Hajime-san Hajime-san deleted the fix-createimagebitmap-overflow branch April 11, 2025 06:50
nayeemrmn pushed a commit that referenced this pull request Apr 11, 2025
@Hajime-san @nayeemrmn
fix(ext/canvas): handle integer overflow in createImageBitmap (#28764)
d42627c 
fixes #28732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic at createImageBitmap
2 participants
@Hajime-san @littledivy