Skip to content

lsp: npm registry completions on module specifiers #15811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsherret opened this issue Sep 7, 2022 · 3 comments · Fixed by #20121
Closed

lsp: npm registry completions on module specifiers #15811

dsherret opened this issue Sep 7, 2022 · 3 comments · Fixed by #20121
Labels
lsp related to the language server node compat

Comments

@dsherret
Copy link
Member

dsherret commented Sep 7, 2022

The LSP should support npm registry completions on module specifiers.

@dsherret dsherret added lsp related to the language server node compat labels Sep 7, 2022
@dsherret dsherret mentioned this issue Sep 19, 2022
25 tasks
@dsherret
Copy link
Member Author

dsherret commented Sep 20, 2022

It seems the endpoint to use is: https://github.com/npm/registry/blob/master/docs/REGISTRY-API.md#get-v1search

We'll definitely need to set boost-exact:false as there are so many typo packages. For example: https://registry.npmjs.org/-/v1/search?text=react-nati%20boost-exact:false&size=5

I believe the change would occur in this function and work similarly to how deno.land/x completions do: https://github.com/denoland/deno/blob/main/cli/lsp/completions.rs#L137

@stale
Copy link

stale bot commented Nov 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 19, 2022
@bartlomieju bartlomieju removed the stale label Nov 20, 2022
@ry
Copy link
Member

ry commented Nov 21, 2022

@crowlKats Maybe something you'd be interested in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lsp related to the language server node compat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants