Skip to content

plugins: argument of ops should support skipped field #11207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garyhai opened this issue Jul 1, 2021 · 1 comment
Closed

plugins: argument of ops should support skipped field #11207

garyhai opened this issue Jul 1, 2021 · 1 comment

Comments

@garyhai
Copy link

garyhai commented Jul 1, 2021

When change the struct TestArgs of test_plugin/src/lib.rs:

#[derive(Debug, Deserialize)]
struct TestArgs {
  val: String,
  //If the value is not present when deserializing, use the Default::default().
  #[serde(default)]
  skip: String,
}

Run the test according to README then get error report:

error: Uncaught TypeError: Error parsing args: serde_v8 error: ExpectedString
  const result = Deno.core.opSync

It is very useful for optional arguments.

@bartlomieju
Copy link
Member

We'll be removing native plugins in the near future #10908 so we won't be adding new features for this API. Respectfully closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants