review comments

Author: ry

core/BUILD.gn

@@ -81,8 +81,11 @@ rust_test("deno_core_http_bench_test") {
 
 rust_executable("snapshot_creator") {
   source_root = "snapshot_creator.rs"
-  deps = [
-    ":deno_core_deps",
+  extern = [
+    {
+      label = ":deno"
+      crate_name = "deno"
+      crate_type = "rlib"
+    },
   ]
-  extern_rlib = main_extern_rlib
 }

core/snapshot_creator.rs

@@ -4,38 +4,23 @@
 // This snapshot program is considered "basic" because the code being
 // snapshotted cannot call ops.
 
-#![allow(dead_code)]
-
-// TODO(ry) DRY up this repeated code from lib.rs
-
-#[macro_use]
-extern crate log;
-extern crate futures;
-extern crate libc;
-
-mod flags;
-mod isolate;
-mod js_errors;
-mod libdeno;
-mod module_specifier;
-mod modules;
-mod shared_queue;
-
-use crate::isolate::js_check;
-use crate::isolate::Isolate;
-use crate::isolate::StartupData;
+extern crate deno;
+
+use deno::js_check;
+use deno::Isolate;
+use deno::StartupData;
 use std::env;
 use std::io::Write;
 
 fn main() {
   let args: Vec<String> = env::args().collect();
   // NOTE: `--help` arg will display V8 help and exit
-  let args = flags::v8_set_flags(args);
+  let args = deno::v8_set_flags(args);
 
   let (snapshot_out_bin, js_filename) = if args.len() == 3 {
     (args[1].clone(), args[2].clone())
   } else {
-    eprintln!("Usage: snapshot_creator <out_dir> <js_filename>");
+    eprintln!("Usage: snapshot_creator <out_filename> <js_filename>");
     std::process::exit(1);
   };