Review comments

Author: ry

js/http.ts

@@ -15,21 +15,21 @@ import { close } from "./files";
 type HttpHandler = (req: ServerRequest, res: ServerResponse) => void;
 
 export class HttpServer implements Closer {
-  private closing = false;
+  private _closing = false;
 
   constructor(readonly rid: number) {
-    assert(rid >= 2);
+    assert(rid >= 2); // rid should be after stdout/stderr
   }
 
   async serve(handler: HttpHandler): Promise<void> {
-    while (this.closing === false) {
+    while (this._closing === false) {
       const [req, res] = await httpAccept(this.rid);
       handler(req, res);
     }
   }
 
   close(): void {
-    this.closing = true;
+    this._closing = true;
     close(this.rid);
   }
 }

src/http_server.rs

@@ -38,12 +38,12 @@ impl Drop for HttpServer {
 
 impl HttpServer {
   pub fn accept(&self) -> impl Future<Item = Transaction, Error = DenoError> {
-    let (transaction_sender, transaction_reciever) =
+    let (transaction_sender, transaction_receiver) =
       oneshot::channel::<Transaction>();
     let tx = self.sender_a.clone();
     tx.send(transaction_sender)
       .map_err(|e| DenoError::from(e))
-      .and_then(|_| transaction_reciever.map_err(|e| DenoError::from(e)))
+      .and_then(|_| transaction_receiver.map_err(|e| DenoError::from(e)))
   }
 }