Fix infinite loop in SubprocessSet::DoWork()

In case fd is invalid loop will be infinite because iterator is not
incremented.

Make cycle more obvious by adding regular iterator into for() loop
and move Subprocess from running_ into finished_ in separate loop.

Author: dendy

src/subprocess-posix.cc

@@ -279,20 +279,23 @@ bool SubprocessSet::DoWork() {
 
   nfds_t cur_nfd = 0;
   for (vector<Subprocess*>::iterator i = running_.begin();
-       i != running_.end(); ) {
+       i != running_.end(); ++i) {
     int fd = (*i)->fd_;
     if (fd < 0)
       continue;
     assert(fd == fds[cur_nfd].fd);
-    if (fds[cur_nfd++].revents) {
+    if (fds[cur_nfd++].revents)
       (*i)->OnPipeReady();
-      if ((*i)->Done()) {
-        finished_.push(*i);
-        i = running_.erase(i);
-        continue;
-      }
+  }
+
+  for (vector<Subprocess*>::iterator i = running_.begin();
+       i != running_.end(); ) {
+    if ((*i)->Done()) {
+      finished_.push(*i);
+      i = running_.erase(i);
+    } else {
+      ++i;
     }
-    ++i;
   }
 
   return IsInterrupted();