Skip to content

Commit f2f5a8a

Browse files
committed
libservo: add FIXME for script-to-constellation logging
Signed-off-by: Delan Azabani <[email protected]>
1 parent 628b1bd commit f2f5a8a

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

components/servo/lib.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1185,6 +1185,9 @@ where
11851185
}
11861186
}
11871187

1188+
/// Copy script process logs to the constellation, for crash detection.
1189+
///
1190+
/// Only used in multiprocess mode (-M, --multiprocess).
11881191
pub fn set_logger(script_to_constellation_chan: ScriptToConstellationChan) {
11891192
let con_logger = FromScriptLogger::new(script_to_constellation_chan);
11901193
let env = env_logger::Env::default();
@@ -1193,7 +1196,8 @@ pub fn set_logger(script_to_constellation_chan: ScriptToConstellationChan) {
11931196
let filter = max(env_logger.filter(), con_logger.filter());
11941197
let logger = BothLogger(env_logger, con_logger);
11951198

1196-
log::set_boxed_logger(Box::new(logger)).expect("Failed to set logger.");
1199+
// FIXME: now fails because tracing-subscriber has already set a logger
1200+
log::set_boxed_logger(Box::new(logger)).ok();
11971201
log::set_max_level(filter);
11981202
}
11991203

0 commit comments

Comments
 (0)