Skip to content

CI: Amazon Bedrock tests fail in PRs from forks #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anakin87 opened this issue Apr 24, 2024 · 0 comments · Fixed by #801
Closed

CI: Amazon Bedrock tests fail in PRs from forks #689

anakin87 opened this issue Apr 24, 2024 · 0 comments · Fixed by #801
Assignees
@anakin87
Labels
bug Something isn't working integration:amazon-bedrock P1

Comments

@anakin87
Copy link
Member

Tests fail because of this:

haystack-core-integrations/.github/workflows/amazon_bedrock.yml

Lines 65 to 66 in 9ed3230

- name: AWS authentication
uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502

Even if unit tests do not need authentication, they can't run because this step fails.
@anakin87 anakin87 added the bug Something isn't working label Apr 24, 2024
@masci masci added P1 P2 and removed P1 labels May 10, 2024
@shadeMe shadeMe self-assigned this Jun 10, 2024
@shadeMe shadeMe added P1 and removed P2 labels Jun 10, 2024
@shadeMe shadeMe assigned anakin87 and unassigned shadeMe Jun 10, 2024
@anakin87 anakin87 mentioned this issue Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anakin87 anakin87

Labels
bug Something isn't working integration:amazon-bedrock P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Amazon Bedrock - skip integration tests from forks anakin87/haystack-core-integrations
4 participants
@masci @shadeMe @davidsbatista @anakin87