Skip to content

Modify the keywords in param.json #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LiangWenshuo1118 opened this issue May 30, 2022 · 2 comments · Fixed by #807
Closed

Modify the keywords in param.json #743

LiangWenshuo1118 opened this issue May 30, 2022 · 2 comments · Fixed by #807
Labels
documentation Improvements or additions to documentation

Comments

@LiangWenshuo1118
Copy link
Contributor

Details
The keywords "model_devi_e_trust_lo" and "model_devi_e_trust_hi" in dpgen/examples seem to be inconsistent with the source code, where they are "model_devi_v_trust_lo" and "model_devi_v_trust_hi".
@LiangWenshuo1118 LiangWenshuo1118 added the wontfix This will not be worked on label May 30, 2022
@wanghan-iapcm
Copy link
Contributor

model_devi_e_trust_lo and model_devi_e_trust_hi are deprecated keys.

@njzjz njzjz added documentation Improvements or additions to documentation and removed wontfix This will not be worked on labels Aug 3, 2022
@njzjz njzjz linked a pull request Aug 4, 2022 that will close this issue
removed model_devi_e_trust_lo and model_devi_e_trust_hi, which have been removed in #79 #807
Merged
@njzjz
Copy link
Member

njzjz commented Aug 4, 2022

Fixed by #807.

@njzjz njzjz closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed model_devi_e_trust_lo and model_devi_e_trust_hi, which have been removed in #79 njzjz/dpgen
3 participants
@njzjz @LiangWenshuo1118 @wanghan-iapcm