Skip to content

Gitlab PKCE auth error on Decap 3.1 #7093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkellydesign opened this issue Feb 6, 2024 · 2 comments · Fixed by #7110
Closed

Gitlab PKCE auth error on Decap 3.1 #7093

kkellydesign opened this issue Feb 6, 2024 · 2 comments · Fixed by #7110
Labels
area: extensions/backends/gitlab type: bug code to address defects in shipped code

Comments

@kkellydesign
Copy link

kkellydesign commented Feb 6, 2024

As of the Decap 3.1 release on February 1, Gitlab PKCE is no longer working. I've tested both Firefox and Chrome.

When I visit /admin and try to log in, it immediately redirects me to Gitlab and shows the following screen:

Screenshot 2024-02-06 at 12 16 40 PM

To Reproduce
config.yml:

backend:
  name: gitlab
  repo: my_repo # Path to your GitHub repository
  auth_type: pkce
  branch: main
  app_id: my_id

admin/index.html – the link below causes the error. But changing the pinned version to 3.1.0-beta.2 fixes it.

   <script src="https://unpkg.com/[email protected]/dist/decap-cms.js"></script>

  <script src="/dist/js/nunjucks-slim.js"></script>
  <script src="/admin/util-bundled.js"></script>
  <script src="/admin/templates.js"></script>
  <script src="/admin/previews.js" type="text/babel"></script>

Applicable Versions:

  • Decap CMS version: 3.1.1
  • Git provider: Gitlab PKCE auth
  • OS: mac locally.. but also on prod, with the CI running on Gitlab.
@kkellydesign kkellydesign added the type: bug code to address defects in shipped code label Feb 6, 2024
@blackb1rd
Copy link
Contributor

I suspected #7014 break gitlab PKCE.

@demshy
Copy link
Member

demshy commented Feb 21, 2024

Closed by automation - please test and reopen if patch 3.1.2 does not fix this.
Thanks @blackb1rd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: extensions/backends/gitlab type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants