Skip to content

Update used double-conversion? #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
catap opened this issue Nov 28, 2024 · 0 comments
Open

Update used double-conversion? #241

catap opened this issue Nov 28, 2024 · 0 comments

Comments

@catap
Copy link

catap commented Nov 28, 2024

Good day,

I had created a port for ejabberd for OpenBSD and during building the port was discovered that ejabberd fails on i386 with error:

===> Compiling /pobj/ejabberd-24.10/ejabberd-24.10/c_src/double-conversion/strtod.cc
===> /pobj/ejabberd-24.10/ejabberd-24.10/c_src/double-conversion/strtod.cc:41:18: error: unused variable 'kMaxExactDoubleIntegerDecimalDigi
ts' [-Werror,-Wunused-const-variable]
static const int kMaxExactDoubleIntegerDecimalDigits = 15;
                 ^
/pobj/ejabberd-24.10/ejabberd-24.10/c_src/double-conversion/strtod.cc:58:21: error: variable 'exact_powers_of_ten' is not needed and will n
ot be emitted [-Werror,-Wunneeded-internal-declaration]
static const double exact_powers_of_ten[] = {
                    ^
/pobj/ejabberd-24.10/ejabberd-24.10/c_src/double-conversion/strtod.cc:84:18: error: unused variable 'kExactPowersOfTenSize' [-Werror,-Wunus
ed-const-variable]
static const int kExactPowersOfTenSize = ARRAY_SIZE(exact_powers_of_ten);
                 ^
3 errors generated.

This error was had come from jiffy's embeded version of double-conversion which was fixed a while ago here: google/double-conversion#123

Here I'm asking: isn't it a good idea to update double-conversion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant