Fix stalling precompilation issue from convert #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for tracking this (in my eyes) esoteric error down, and fixing it! |
|
No worries, thanks for the speedy response! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've noticed that for some reason, when I try to precompile GaussianMixtures on Julia v1.11.3 (and also on v1.10.8) the precompilation hangs indefinitely. When I ctrl+c out of it, it says the last line it got stuck on was src/gmms.jl line 186.
After a little fiddling, I think the issue may have been that the convert method only used one parametric type for
GMMand not both. Once I fixed this, the issue was resolved, so I think that works?I'm not as familiar with this part of the code, so would appreciate any comments/feedback!
Thanks :)