Add error code

Author: zprodev

idb-cache.ts

@@ -19,6 +19,12 @@ const DATA_TYPE = {
 const isIOS = /iP(hone|(o|a)d);/.test(window.navigator.userAgent); 
 
 export default class IDBCache {
+  public static ERROR = {
+    INVALID_ARGUMENT : 1,
+    CANNOT_OPEN : 2,
+    REQUEST_FAILED : 3,
+    GET_EMPTY : 4,
+  }
   private _indexedDB : IDBFactory;
   private _dbName : string;
   private _maxSize : number = 52428800; // 50MB
@@ -57,7 +63,7 @@ export default class IDBCache {
     return new Promise((resolve:Function, reject:Function) => {
       this._serializeData(value, (data, meta) => {
         if(meta.size === 0){
-          reject();
+          reject(IDBCache.ERROR.INVALID_ARGUMENT);
           return;
         }
         this._open((db) => {
@@ -89,14 +95,14 @@ export default class IDBCache {
             transaction.oncomplete = null;
             transaction.onerror = null;
             transaction.onabort = null;
-            reject();
+            reject(IDBCache.ERROR.REQUEST_FAILED);
           };
 
           transaction.onabort = () => {
             transaction.oncomplete = null;
             transaction.onerror = null;
             transaction.onabort = null;
-            reject();
+            reject(IDBCache.ERROR.REQUEST_FAILED);
           }
 
           try{
@@ -108,7 +114,7 @@ export default class IDBCache {
           }
         }, () => {
           // Open error
-          reject();
+          reject(IDBCache.ERROR.CANNOT_OPEN);
         });  
       })
     });
@@ -134,19 +140,20 @@ export default class IDBCache {
               resolve(data);
             });
           }else{
-            reject();
+            // Can not find or expired
+            reject(IDBCache.ERROR.GET_EMPTY);
           }
         };
 
         request.onerror = () => {
           request.onsuccess = null;
           request.onerror = null;
-          reject();
+          reject(IDBCache.ERROR.REQUEST_FAILED);
         };
       },
       () => {
         // Open error
-        reject();
+        reject(IDBCache.ERROR.CANNOT_OPEN);
       });
     });
   }
@@ -178,14 +185,14 @@ export default class IDBCache {
           transaction.oncomplete = null;
           transaction.onerror = null;
           transaction.onabort = null;
-          reject();
+          reject(IDBCache.ERROR.REQUEST_FAILED);
         };
 
         transaction.onabort = () => {
           transaction.oncomplete = null;
           transaction.onerror = null;
           transaction.onabort = null;
-          reject();
+          reject(IDBCache.ERROR.REQUEST_FAILED);
         }
 
         try{
@@ -198,7 +205,7 @@ export default class IDBCache {
       },
       () => {
         // Open error
-        reject();
+        reject(IDBCache.ERROR.CANNOT_OPEN);
       });
     });
   }

test/index.js

@@ -13,6 +13,24 @@ describe('Basic', function() {
     it('Blob', function() {
       return idbc.set('baz', new Blob([new ArrayBuffer(128)]));
     });
+    it('empty string is ERROR.INVALID_ARGUMENT', function() {
+      return idbc.set('empty', '').then(
+        () => assert.fail(),
+        (errorCode) => assert.deepEqual(IDBCache.ERROR.INVALID_ARGUMENT, errorCode)
+      );
+    });
+    it('empty ArrayBuffer is ERROR.INVALID_ARGUMENT', function() {
+      return idbc.set('empty', new ArrayBuffer()).then(
+        () => assert.fail(),
+        (errorCode) => assert.deepEqual(IDBCache.ERROR.INVALID_ARGUMENT, errorCode)
+      );
+    });
+    it('empty Blob is ERROR.INVALID_ARGUMENT', function() {
+      return idbc.set('empty', new Blob([new ArrayBuffer()])).then(
+        () => assert.fail(),
+        (errorCode) => assert.deepEqual(IDBCache.ERROR.INVALID_ARGUMENT, errorCode)
+      );
+    });
   });
   describe('#update', function() {
     it('string', function() {
@@ -43,6 +61,12 @@ describe('Basic', function() {
         assert.strictEqual(data.size, 256);
       });
     });
+    it('Can not find is ERROR.GET_EMPTY', function() {
+      return idbc.get('empty').then(
+        () => assert.fail(),
+        (errorCode) => assert.deepEqual(IDBCache.ERROR.GET_EMPTY, errorCode)
+      );
+    });
   });
   describe('#delete', function() {
     it('string', function() {
@@ -175,10 +199,13 @@ describe('Limit Management', function() {
         () => idbc.get('foo')
       ).then(
         () => assert.fail(), // foo should have been deleted
-        () => idbc.get('bar')
+        (errorCode) => {
+          assert.deepEqual(IDBCache.ERROR.GET_EMPTY, errorCode)
+          return idbc.get('bar');
+        }
       ).then(
         () => assert.fail(), // bar should have been deleted
-        () => assert.ok(true)
+        (errorCode) => assert.deepEqual(IDBCache.ERROR.GET_EMPTY, errorCode)
       );
     });
 
@@ -198,7 +225,7 @@ describe('Limit Management', function() {
         () => idbc.get('bar')
       ).then(
         () => assert.fail(), // bar should have been deleted
-        () => assert.ok(true)
+        (errorCode) => assert.deepEqual(IDBCache.ERROR.GET_EMPTY, errorCode)
       );
     });
   });