Attempt loading goofi patches with invalid params instead of crashing

Author: dav0dea

src/goofi/node.py

@@ -15,7 +15,7 @@
 from goofi.data import Data, DataType
 from goofi.message import Message, MessageType
 from goofi.node_helpers import InputSlot, NodeRef, OutputSlot
-from goofi.params import NodeParams
+from goofi.params import InvalidParamError, NodeParams
 
 
 class MultiprocessingForbiddenError(Exception):
@@ -496,7 +496,15 @@ def create(cls, initial_params: Optional[Dict[str, Dict[str, Any]]] = None, retr
         in_slots, out_slots, params = cls._configure(cls)
         # integrate initial parameters if they are provided
         if initial_params is not None:
-            params.update(initial_params)
+            try:
+                params.update(initial_params)
+            except InvalidParamError:
+                print(
+                    "\n====================== ERROR ======================\n"
+                    f"Setting parameters failed for {cls.__name__}. This is likely due to updates"
+                    " in the node's code. Make sure to reconfigure the node."
+                    "\n===================================================\n"
+                )
 
         tries = 0
         while True:
@@ -540,9 +548,19 @@ def create_local(cls, initial_params: Optional[Dict[str, Dict[str, Any]]] = None
         """
         # generate arguments for the node
         in_slots, out_slots, params = cls._configure(cls)
+
         # integrate initial parameters if they are provided
         if initial_params is not None:
-            params.update(initial_params)
+            try:
+                params.update(initial_params)
+            except InvalidParamError:
+                print(
+                    "\n====================== ERROR ======================\n"
+                    f"Setting parameters failed for {cls.__name__}. This is likely due to updates"
+                    " in the node's code. Make sure to reconfigure the node."
+                    "\n===================================================\n"
+                )
+
         conn1, conn2 = Connection.create()
         # instantiate the node in the current process
         node = cls(conn2, in_slots, out_slots, params, NodeEnv.LOCAL)

src/goofi/params.py

@@ -143,6 +143,10 @@ def add_doc_attribute(cls):
 }
 
 
+class InvalidParamError(Exception):
+    pass
+
+
 class NodeParams:
     """
     A class for storing node parameters, which store the configuration state of the node, and are exposed
@@ -238,13 +242,20 @@ def update(self, params: Dict[str, Dict[str, Any]]):
         `params` : Dict[str, Dict[str, Any]]
             A dictionary of parameter groups, where each group is a dictionary of parameter names and values.
         """
+        encountered_invalid_params = False
+
         # TODO: avoid code duplication with __init__
         for group, params in params.items():
+            if group not in self._data:
+                encountered_invalid_params = True
+                print(f"Invalid parameter group '{group}'.")
+                continue
+
             for name, param in params.items():
-                if group not in self._data:
-                    raise ValueError(f"Parameter group '{group}' does not exist.")
                 if name not in self._data[group]._fields:
-                    raise ValueError(f"Parameter '{name}' does not exist in group '{group}'.")
+                    encountered_invalid_params = True
+                    print(f"Invalid parameter '{name}' in group '{group}'.")
+                    continue
 
                 if not isinstance(param, Param):
                     if isinstance(param, dict):
@@ -265,6 +276,9 @@ def update(self, params: Dict[str, Dict[str, Any]]):
                     # update the entire parameter object
                     self._data[group] = self._data[group]._replace(**{name: param})
 
+        if encountered_invalid_params:
+            raise InvalidParamError("Invalid parameters encountered.")
+
     def serialize(self) -> Dict[str, Dict[str, Any]]:
         """
         Serialize the parameter values to a dictionary.