Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: telepresence formula quietly installs broken binary #19

Closed
nicks opened this issue Dec 16, 2022 · 1 comment · Fixed by telepresenceio/telepresence#3282
Closed

linux: telepresence formula quietly installs broken binary #19

nicks opened this issue Dec 16, 2022 · 1 comment · Fixed by telepresenceio/telepresence#3282

Comments

@nicks
Copy link

nicks commented Dec 16, 2022 •
edited
Loading

the current formula unconditionally installs a darwin binary:

homebrew-blackbird/Formula/telepresence.rb

Line 6 in 90de1d1

url "https://app.getambassador.io/download/tel2/darwin/amd64/2.9.5/telepresence"

But homebrew supports Linux now!
https://docs.brew.sh/Homebrew-on-Linux

If I try to install on Linux, I get a broken binary. 😭

Recommended fixes:

  • Emit an error if a linux user tries to install the formula, OR
  • Fix the formula to detect linux and use the linux binary.

(Homebrew has nice on_macos and on_linux directives that make this easy now, here's an example - https://github.com/tilt-dev/homebrew-tap/blob/master/tilt.rb#L10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add brew support for all binaries lhriley/telepresence
2 participants
@nicks @lhriley