[fix][test] Cleanup resources if starting PulsarService fails in PulsarTestContext (apache#21467)

Author: lhotari

pulsar-broker/src/test/java/org/apache/pulsar/broker/testcontext/PulsarTestContext.java

@@ -193,6 +193,10 @@ public static Builder builderForNonStartableContext() {
      * @throws Exception if there is an error closing the resources
      */
     public void close() throws Exception {
+        callCloseables(closeables);
+    }
+
+    private static void callCloseables(List<AutoCloseable> closeables) {
         for (int i = closeables.size() - 1; i >= 0; i--) {
             try {
                 closeables.get(i).close();
@@ -226,6 +230,7 @@ public static class Builder {
         protected ServiceConfiguration svcConfig = initializeConfig();
         protected Consumer<ServiceConfiguration> configOverrideCustomizer = this::defaultOverrideServiceConfiguration;
         protected Function<BrokerService, BrokerService> brokerServiceCustomizer = Function.identity();
+        protected PulsarTestContext otherContextToClose;
 
         /**
          * Initialize the ServiceConfiguration with default values.
@@ -401,7 +406,15 @@ public Builder reuseSpyConfig(PulsarTestContext otherContext) {
          * The other PulsarTestContext will be closed when this one is closed.
          */
         public Builder chainClosing(PulsarTestContext otherContext) {
-            registerCloseable(otherContext);
+            otherContextToClose = otherContext;
+            return this;
+        }
+
+        /**
+         * Registers a closeable to close as the last one by prepending it to the closeables list.
+         */
+        public Builder prependCloseable(AutoCloseable closeable) {
+            closeables.add(0, closeable);
             return this;
         }
 
@@ -537,9 +550,14 @@ public final PulsarTestContext build() {
                 try {
                     super.pulsarService.start();
                 } catch (Exception e) {
+                    callCloseables(super.closeables);
+                    super.closeables.clear();
                     throw new RuntimeException(e);
                 }
             }
+            if (otherContextToClose != null) {
+                prependCloseable(otherContextToClose);
+            }
             brokerService(super.pulsarService.getBrokerService());
             return super.build();
         }