Skip to content

Commit 2f89614

Browse files
committed
Change class name to make its intent evident
1 parent e0ba497 commit 2f89614

File tree

3 files changed

+9
-14
lines changed

3 files changed

+9
-14
lines changed

jvector-examples/src/main/java/io/github/jbellis/jvector/example/Bench.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import io.github.jbellis.jvector.example.util.DataSet;
2222
import io.github.jbellis.jvector.example.util.DownloadHelper;
2323
import io.github.jbellis.jvector.example.util.Hdf5Loader;
24-
import io.github.jbellis.jvector.example.yaml.Datasets;
24+
import io.github.jbellis.jvector.example.yaml.DatasetCollection;
2525
import io.github.jbellis.jvector.graph.disk.feature.FeatureId;
2626
import io.github.jbellis.jvector.vector.VectorSimilarityFunction;
2727

@@ -85,7 +85,7 @@ public static void main(String[] args) throws IOException {
8585
}
8686

8787
private static void execute(Pattern pattern, List<Function<DataSet, CompressorParameters>> buildCompression, List<EnumSet<FeatureId>> featureSets, List<Function<DataSet, CompressorParameters>> compressionGrid, List<Integer> mGrid, List<Integer> efConstructionGrid, List<Float> neighborOverflowGrid, List<Boolean> addHierarchyGrid, Map<Integer, List<Double>> topKGrid, List<Boolean> usePruningGrid) throws IOException {
88-
var datasets = Datasets.load();
88+
var datasets = DatasetCollection.load();
8989
var datasetNames = datasets.getAll().stream().filter(dn -> pattern.matcher(dn).find()).collect(Collectors.toList());
9090
System.out.println("Executing the following datasets: " + datasetNames);
9191

jvector-examples/src/main/java/io/github/jbellis/jvector/example/BenchYAML.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,11 @@
1919
import io.github.jbellis.jvector.example.util.DataSet;
2020
import io.github.jbellis.jvector.example.util.DownloadHelper;
2121
import io.github.jbellis.jvector.example.util.Hdf5Loader;
22-
import io.github.jbellis.jvector.example.yaml.Datasets;
22+
import io.github.jbellis.jvector.example.yaml.DatasetCollection;
2323
import io.github.jbellis.jvector.example.yaml.MultiConfig;
24-
import org.yaml.snakeyaml.Yaml;
2524

26-
import java.io.File;
27-
import java.io.FileInputStream;
2825
import java.io.IOException;
29-
import java.io.InputStream;
3026
import java.util.Arrays;
31-
import java.util.List;
3227
import java.util.regex.Pattern;
3328
import java.util.stream.Collectors;
3429

@@ -49,7 +44,7 @@ public static void main(String[] args) throws IOException {
4944
}
5045

5146
private static void execute(Pattern pattern) throws IOException {
52-
var datasets = Datasets.load();
47+
var datasets = DatasetCollection.load();
5348
var datasetNames = datasets.getAll().stream().filter(dn -> pattern.matcher(dn).find()).collect(Collectors.toList());
5449
System.out.println("Executing the following datasets: " + datasetNames);
5550

jvector-examples/src/main/java/io/github/jbellis/jvector/example/yaml/Datasets.java renamed to jvector-examples/src/main/java/io/github/jbellis/jvector/example/yaml/DatasetCollection.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,23 @@
99
import java.util.List;
1010
import java.util.Map;
1111

12-
public class Datasets {
12+
public class DatasetCollection {
1313
private static final String defaultFile = "./jvector-examples/yaml-examples/datasets.yml";
1414

1515
public final Map<String, List<String>> datasetNames;
1616

17-
private Datasets(Map<String, List<String>> datasetNames) {
17+
private DatasetCollection(Map<String, List<String>> datasetNames) {
1818
this.datasetNames = datasetNames;
1919
}
2020

21-
public static Datasets load() throws IOException {
21+
public static DatasetCollection load() throws IOException {
2222
return load(defaultFile);
2323
}
2424

25-
public static Datasets load(String file) throws IOException {
25+
public static DatasetCollection load(String file) throws IOException {
2626
InputStream inputStream = new FileInputStream(file);
2727
Yaml yaml = new Yaml();
28-
return new Datasets(yaml.load(inputStream));
28+
return new DatasetCollection(yaml.load(inputStream));
2929
}
3030

3131
public List<String> getAll() {

0 commit comments

Comments
 (0)