Create empty profiles record on first sign of actor_id, closes #4

Author: simonw

datasette_profiles/__init__.py

@@ -37,6 +37,33 @@ async def inner():
     return inner
 
 
+_track_event_seen_actor_ids = set()
+
+
+@hookimpl
+def permission_allowed(datasette, actor):
+    actor_id = actor.get("id") if actor else None
+    if not actor_id:
+        return
+    if actor_id in _track_event_seen_actor_ids:
+        return
+
+    async def inner():
+        db = datasette.get_internal_database()
+        # Insert into profiles if it doesn't exist
+        await db.execute_write(
+            """
+            insert into profiles (id)
+            values (:id)
+            on conflict (id) do nothing
+            """,
+            {"id": str(actor_id)},
+        )
+        _track_event_seen_actor_ids.add(actor_id)
+
+    return inner
+
+
 # Regular expression to extract base64 data from Data URL
 DATA_URL_RE = re.compile(r"data:image/(jpeg|png|gif|webp);base64,(.*)")
 

tests/test_profiles.py

@@ -3,9 +3,21 @@
 
 
 @pytest.mark.asyncio
-async def test_plugin_is_installed():
+async def test_profiles_table_populated_on_visit():
     datasette = Datasette(memory=True)
-    response = await datasette.client.get("/-/plugins.json")
-    assert response.status_code == 200
-    installed_plugins = {p["name"] for p in response.json()}
-    assert "datasette-profiles" in installed_plugins
+    await datasette.invoke_startup()
+    internal_db = datasette.get_internal_database()
+    for actor_id in ("user1", "user2"):
+        assert not (
+            await internal_db.execute(
+                "select count(*) from profiles where id = ?", (actor_id,)
+            )
+        ).single_value()
+        await datasette.client.get(
+            "/", cookies={"ds_actor": datasette.client.actor_cookie({"id": actor_id})}
+        )
+        assert (
+            await internal_db.execute(
+                "select count(*) from profiles where id = ?", (actor_id,)
+            )
+        ).single_value() == 1