Add external_access_enabled parameter to Metastore API (Fixes #1200) #1216
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Hi there, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR adds support for the
external_access_enabledparameter in the Databricks Metastore API to resolve issue #1200.WHAT:
ExternalAccessEnabledfield to theUpdateMetastorestruct inservice/catalog/model.goservice/catalog/metastores_usage_test.goto demonstrate usage of the new fieldjson:"external_access_enabled,omitempty"for API compatibilityWHY:
This change is needed because the current implementation of the Databricks metastore Terraform resources does not support the option of
external_access_enabled. This parameter is documented in the Databricks API reference and allows or prevents non-Databricks Runtime clients from directly accessing entities under the metastore.Adding this field will enable Terraform users to control this important security setting through the Databricks Terraform provider, as requested in issue #1200.
How is this tested?
The change has been tested by:
go build -mod vendor ./...to verify compilationUpdateMetastorecallThe full end-to-end functionality would be tested when integrated with the Databricks Terraform Provider, but this PR only implements the necessary SDK changes to enable that integration.
Fixes #1200