Skip to content

Include specific JS code in themed build #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dascritch opened this issue Apr 3, 2021 · 1 comment
Open

Include specific JS code in themed build #132

dascritch opened this issue Apr 3, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@dascritch
Copy link
Owner

It's quite easy : we already build a javascript to include CSS and HTML template in the ./make.sh system. We can see if we have a specific.js , include it in a document.addEventListener('CPU_ready', function, {once:true});

It won't have access to most of the private methods, but it may be enough.

@dascritch dascritch added enhancement New feature or request good first issue Good for newcomers labels Apr 3, 2021
@dascritch
Copy link
Owner Author

Watch out, as CPU_ready is triggered for EACH webcomponent started on the page. If you've got 3 players and 1 controller, you will get 4 calls.

@dascritch dascritch added this to the 7.1 milestone Apr 28, 2021
@dascritch dascritch changed the title Add a way to include specific JS code in themed build Include specific JS code in themed build Sep 28, 2022
@dascritch dascritch modified the milestones: 7.1, 8.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant