Skip to content

Commit 5a39fdc

Browse files
committed
Merge tag 'web-v1.1.1'
2 parents b90b63d + 222164b commit 5a39fdc

File tree

5 files changed

+17
-9
lines changed

5 files changed

+17
-9
lines changed

web/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@
55
don't exist.
66
- Fixed generation of variadic arguments to generate 4 optional parameters.
77

8+
## 1.1.1
9+
10+
- Deprecated `Node.text` extension. Use `Node.textContent` instead.
11+
- Deprecated `[]` extensions on `Storage`.
12+
813
## 1.1.0
914

1015
- Added `HttpStatus` class that declares http status codes. This is a copy of

web/example/example.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ import 'package:web/web.dart';
66

77
void main() {
88
final div = document.querySelector('div')!;
9-
div.text = 'Text set at ${DateTime.now()}';
9+
div.textContent = 'Text set at ${DateTime.now()}';
1010
}

web/lib/src/helpers/events/streams.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@ class _EventStreamSubscription<T extends html.Event>
176176
// `dart:html` it would have printed 1, 2, 4, 3
177177
//
178178
// ```dart
179-
// import 'package:web/helpers.dart';
179+
// import 'package:web/web.dart';
180180
//
181-
// main() {
181+
// void main() {
182182
// print('1');
183183
// final body = document.body!;
184184
// body.onTouchStart.first.whenComplete(() {

web/lib/src/helpers/extensions.dart

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ extension HTMLCanvasElementGlue on HTMLCanvasElement {
5959
}
6060

6161
extension CanvasRenderingContext2DGlue on CanvasRenderingContext2D {
62+
@Deprecated('See CanvasRenderingContext2D.drawImage')
6263
void drawImageScaled(
6364
CanvasImageSource image,
6465
double dx,
@@ -70,6 +71,7 @@ extension CanvasRenderingContext2DGlue on CanvasRenderingContext2D {
7071
}
7172

7273
extension NodeGlue on Node {
74+
@Deprecated('See Node.textContent')
7375
set text(String s) => textContent = s;
7476
@Deprecated('See Node.appendChild()')
7577
Node append(Node other) => appendChild(other);
@@ -98,7 +100,9 @@ extension TouchGlue on Touch {
98100
}
99101

100102
extension StorageGlue on Storage {
103+
@Deprecated('Use Storage.getItem instead')
101104
String? operator [](String key) => getItem(key);
105+
@Deprecated('Use Storage.setItem instead')
102106
void operator []=(String key, String value) => setItem(key, value);
103107
}
104108

@@ -119,9 +123,8 @@ extension XMLHttpRequestGlue on XMLHttpRequest {
119123
// from Closure's goog.net.Xhrio.getResponseHeaders.
120124
final headers = <String, String>{};
121125
final headersString = getAllResponseHeaders();
122-
final headersList =
123-
LineSplitter.split(headersString).where((header) => header.isNotEmpty);
124-
for (final header in headersList) {
126+
for (final header in LineSplitter.split(headersString)
127+
.where((header) => header.isNotEmpty)) {
125128
final split = header.split(': ');
126129
if (split.length <= 1) {
127130
continue;

web/test/helpers_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ void main() {
2323

2424
test('Converts a JS list to a dart list using JSImmutableListWrapper', () {
2525
final div = (document.createElement('div'))
26-
..append(document.createElement('div')..text = '1')
27-
..append(document.createElement('div')..text = '2')
28-
..append(document.createElement('div')..text = '3');
26+
..append(document.createElement('div')..textContent = '1')
27+
..append(document.createElement('div')..textContent = '2')
28+
..append(document.createElement('div')..textContent = '3');
2929

3030
final List<Node> dartList =
3131
JSImmutableListWrapper<NodeList, Node>(div.querySelectorAll('div'));

0 commit comments

Comments
 (0)