Skip to content

Commit 329c6df

Browse files
authored
fix windows failures (#2244)
Fixes #2243 by not creating files that end in a `.`. https://gist.github.com/jakemac53/845b60847dbda53f93aeed8056d5fbd2 illustrates what I think is the core of the issue. I would expect this to print false and also hit the catch block for every case. However, on 3.4.0, in the very first case the copy actually succeeds even though it claims the file doesn't exist. I filed dart-lang/sdk#55972 about this.
1 parent 777631b commit 329c6df

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

pkgs/test_core/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
## 0.6.5-wip
22

33
* Increase SDK constraint to ^3.4.0.
4+
* Ensure we don't create files ending in a `.`, this breaks windows.
45

56
## 0.6.4
67

pkgs/test_core/lib/src/runner/package_version.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ Future<String> get rootPackageLanguageVersionComment =>
1818
final _rootPackageLanguageVersionComment = DetachingFuture(() async {
1919
var packageConfig = await loadPackageConfigUri(await packageConfigUri);
2020
var rootPackage = packageConfig.packageOf(Uri.file(p.absolute('foo.dart')));
21-
if (rootPackage == null) return '';
21+
if (rootPackage == null) return '// <unknown-language-version>';
2222
return '// @dart=${rootPackage.languageVersion}';
2323
}());

0 commit comments

Comments
 (0)