fix api token initialization #722
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Martinez <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
==========================================
- Coverage 62.52% 60.96% -1.57%
==========================================
Files 56 58 +2
Lines 4139 4350 +211
==========================================
+ Hits 2588 2652 +64
- Misses 1425 1568 +143
- Partials 126 130 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mikeee
reviewed
Apr 22, 2025
| func newAuthToken() *authToken { | ||
| apiToken := os.Getenv(apiTokenEnvVarName) | ||
| if apiToken != "" { | ||
| logger.Println("client uses API token") |
There was a problem hiding this comment.
Suggested change
| logger.Println("client uses API token") | |
| logger.Println("API Token loaded from the environment variable") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that currently, if an API token is provided, it is not used to create the grpc connection, it is only used in subsequent requests after the connection is stablished.
This PR fixes that forcing the API token env var to be read when initializing the authToken holder
Issue reference
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: