feat: add wrap pipe to add a prefix and a suffix to a string
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacing
maxime1992
commented
Jul 12, 2018
src/pipes/string/wrap.ts
Outdated
| @@ -10,6 +10,6 @@ export class WrapPipe implements PipeTransform { | |||
|
|
|||
| return (!!prefix && isString(prefix) ? prefix: '') + | |||
| str + | |||
| (!!suffix && isString(suffix)? suffix: ''); | |||
| (!!suffix && isString(suffix) ? suffix: ''); | |||
There was a problem hiding this comment.
Would you be ok to have your project formatted with Prettier?
You wouldn't have to bother reviewing styles like that :)
There was a problem hiding this comment.
Is that suppose to act as a linter? how's it different from tslint?
danrevah
approved these changes
Jul 12, 2018
|
@maxime1992 Thanks! |
|
released to version 2.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #112