Skip to content

File editor CSS and JS loaded from Cloudflare #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniporr opened this issue Apr 21, 2025 · 1 comment
Closed

File editor CSS and JS loaded from Cloudflare #251

daniporr opened this issue Apr 21, 2025 · 1 comment

Comments

@daniporr
Copy link

As already mentioned in home-assistant/addons#3986 (comment)

Describe the issue you are experiencing

The "File editor" (Configurator) add-on currently loads some CSS and JS files from https://cdnjs.cloudflare.com.

Given that most users install HA for privacy reasons, I believe this is a bug.

And it can be easily fixed!
It is simply a matter of downloading those few files from Cloudflare and loading them locally, as is already done for the other CSS and JS files of the "File editor".
As CSS and JS files are already loaded locally, I see no issues with this approach.

Furthermore, those CSS/JS files from Cloudflare are very small, so there is no problem related to the size of the "File editor".
I believe that any HA user would sacrifice a few KBs for greater privacy.

Which add-on are you reporting an issue with?

File editor

What is the version of the add-on?

5.8.0

Steps to reproduce the issue

  1. Install the "File editor"
  2. Open the "File editor"
  3. Look at the requests made when loading it, or look at the page source

The same could be seen by looking at the source files, but I cannot locate them here.

@danielperna84
Copy link
Owner

Duplicate of #177

Please read through that issue to see, why it's not as easy as you think. I don't have the capacitiy to work on this project. But I would accept a pull request, where someone else contributes this feature. Since nobody has done this since 2019, I wouldn't hold my breath though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants