Skip to content

Commit e4757cc

Browse files
committed
#716 Increased precision of percentages in CsvSummary and TextSummary reports (contributed by @tomap)
2 parents e530e91 + 9e9bee8 commit e4757cc

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

src/Readme.txt

+1
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ CHANGELOG
7070
5.4.2.0
7171

7272
* Fix: #700 Fixed handling of .netconfig files (sourceDirectories, reportTypes, plugins, assemblyFilters, etc.)
73+
* Fix: #716 Increased precision of percentages in CsvSummary and TextSummary reports (contributed by @tomap)
7374
* Fix: #719 Fixed badges in MarkdownAssembliesSummary report
7475

7576
5.4.1.0

src/ReportGenerator.Core/Reporting/Builders/CsvSummaryReportBuilder.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
110110
reportTextWriter.WriteLine(
111111
"{0};{1}",
112112
ReportResources.Coverage2,
113-
summaryResult.CoverageQuota.HasValue ? summaryResult.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty);
113+
summaryResult.CoverageQuota.HasValue ? summaryResult.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty);
114114
reportTextWriter.WriteLine(
115115
"{0};{1}",
116116
ReportResources.CoveredLines,
@@ -134,7 +134,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
134134
reportTextWriter.WriteLine(
135135
"{0};{1}",
136136
assembly.Name,
137-
assembly.CoverageQuota.HasValue ? assembly.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty);
137+
assembly.CoverageQuota.HasValue ? assembly.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty);
138138

139139
if (assembly.Classes.Any())
140140
{
@@ -146,7 +146,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
146146
reportTextWriter.WriteLine(
147147
"{0};{1}",
148148
@class.Name,
149-
@class.CoverageQuota.HasValue ? @class.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty);
149+
@class.CoverageQuota.HasValue ? @class.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty);
150150
}
151151
}
152152

src/ReportGenerator.Core/Reporting/Builders/TextSummaryReportBuilder.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
106106
reportTextWriter.WriteLine(" {0} {1}", ReportResources.Assemblies2, assembliesWithClasses.Count().ToString(CultureInfo.InvariantCulture));
107107
reportTextWriter.WriteLine(" {0} {1}", ReportResources.Classes, assembliesWithClasses.SelectMany(a => a.Classes).Count().ToString(CultureInfo.InvariantCulture));
108108
reportTextWriter.WriteLine(" {0} {1}", ReportResources.Files2, assembliesWithClasses.SelectMany(a => a.Classes).SelectMany(a => a.Files).Distinct().Count().ToString(CultureInfo.InvariantCulture));
109-
reportTextWriter.WriteLine(" {0} {1}", ReportResources.Coverage2, summaryResult.CoverageQuota.HasValue ? summaryResult.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty);
109+
reportTextWriter.WriteLine(" {0} {1}", ReportResources.Coverage2, summaryResult.CoverageQuota.HasValue ? summaryResult.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty);
110110
reportTextWriter.WriteLine(" {0} {1}", ReportResources.CoveredLines, summaryResult.CoveredLines.ToString(CultureInfo.InvariantCulture));
111111
reportTextWriter.WriteLine(" {0} {1}", ReportResources.UncoveredLines, (summaryResult.CoverableLines - summaryResult.CoveredLines).ToString(CultureInfo.InvariantCulture));
112112
reportTextWriter.WriteLine(" {0} {1}", ReportResources.CoverableLines, summaryResult.CoverableLines.ToString(CultureInfo.InvariantCulture));
@@ -146,7 +146,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
146146

147147
foreach (var assembly in assembliesWithClasses)
148148
{
149-
string assemblyQuota = assembly.CoverageQuota.HasValue ? assembly.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty;
149+
string assemblyQuota = assembly.CoverageQuota.HasValue ? assembly.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty;
150150
reportTextWriter.WriteLine();
151151
reportTextWriter.WriteLine(
152152
"{0}{1} {2}",
@@ -156,7 +156,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
156156

157157
foreach (var @class in assembly.Classes)
158158
{
159-
string classQuota = @class.CoverageQuota.HasValue ? @class.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty;
159+
string classQuota = @class.CoverageQuota.HasValue ? @class.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty;
160160
reportTextWriter.WriteLine(
161161
" {0}{1} {2}",
162162
@class.DisplayName,

0 commit comments

Comments
 (0)