Push to Rust 2024

[DorianCoding]

Hello,

Rust 1.85 was published with rust-edition version 2024. I know you want to enforce a N-2 version compatibility but it might be of interest to think about pushing vaultwarden to version 2024 and rust 1.85. After small checks, it seems it compiles without any modification to the code. Biggest changes includes if let and some other stuffs.

Thanks.

[BlackDex]

We will have to wait for at least v1.87.0 before we switch at the minimum. But maybe a bit later even.

As far as i know, no changes have to be done to convert to 2024 apart of some added allows to satisfy clippy/compiler lints.

[BlackDex]

It works just fine for me.
The only thing i adjusted were in the Cargo.toml, and I set the MSRV to 1.85.0 just to be sure.

And i can run cargo build just fine.

cargo +stable build --features sqlite

I also tested to see if i was really using 2024, and changed the edition back to 2021 compiler did everything again, and the binaries were different.

The warnings you get looks to me that you are not using an up-to-date codebase.

diff --git a/Cargo.toml b/Cargo.toml
index 68ef1866..b91f3473 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -4,8 +4,8 @@ workspace = { members = ["macros"] }
 name = "vaultwarden"
 version = "1.0.0"
 authors = ["Daniel García <[email protected]>"]
-edition = "2021"
-rust-version = "1.83.0"
+edition = "2024"
+rust-version = "1.85.0"
 resolver = "2"

[tessus]

The current code base compiles just fine with 1.85.0.

I just pointed out that if you convert the code from 2021 to 2024 edition (which is done via the fix subcommand, according to the docs, unless I misunderstood), these warnings pop up and 20 files are also adjusted. e.g. if let constructs are replaced by match constructs, if the temp scopes are violated.

[BlackDex]

There is no need to run the fix. It compiles and clippy just fine with edition set to 2024.

[tessus]

ok, in that case I apparently misunderstood the migration section of the release notes.
Sorry for the noise.

[BlackDex]

You didn't misunderstood it. But it is just not needed, since we already changed everything and added the right annotations on functions where needed.