Skip to content

Configuration Names and Descriptions as Variables #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

theadamcraig
Copy link
Contributor

I've added variables for configuration names and descriptions to make one set of variables that need updated to update the configurations throughout the entire script.

This will make the script easier to customize for people who want different names and application sets for their configurations.

Adam Caudill added 2 commits May 15, 2023 11:07
Changing Configuration names and descriptions to being variables to make it easier to make them consistent throughout the script.
@drtaru
Copy link
Contributor

drtaru commented May 15, 2023

The only issue I see with this is it implies a limitation of three configurations which is not the case, you can have as many as you want / need.

@dan-snelson
Copy link
Collaborator

dan-snelson commented May 15, 2023

Thanks, @theadamcraig!

Fair point, @drtaru, but I do see this as an improvement to the currently hard-coded Configuration labels we're using internally.

@dan-snelson dan-snelson changed the base branch from main to 1.11.0 May 15, 2023 15:27
@dan-snelson
Copy link
Collaborator

@theadamcraig: I just changed the base branch from main to 1.11.0 and there are now conflicts.

Please resolve. Thanks.

@theadamcraig
Copy link
Contributor Author

I've updated to resolve the conflicts.

@drtaru I hope that these changes will help users who want to add a 4th, or more, configurations find out where they need to be updated by being able to easily search and find variable names.

Fixed variable declaration for configurationThreeName
@dan-snelson dan-snelson merged commit 382f939 into setup-your-mac:1.11.0 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants