Skip to content

Switching macOS system theme switches background panel color but does not update text color #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jb55 opened this issue May 11, 2024 · 5 comments

Comments

@jb55
Copy link
Contributor

jb55 commented May 11, 2024

Not sure what's up here

@kernelkind
Copy link
Member

https://groups.google.com/a/damus.io/g/patches/c/Q2MoZyuIiLs/m/zjYzGqCLAAAJ

See the description for this patch series:

Note: I don't believe egui currently supports setting the default
'dark' and 'light' themes, so the correct light/dark themes specified
in LightTheme and DarkTheme won't get switched to when the user
changes their system theme; the app theme will be changed to the
egui::Visuals::dark() or egui::Visuals::light().

@jb55
Copy link
Contributor Author

jb55 commented May 11, 2024 via email

@kernelkind
Copy link
Member

hmm maybe we should report/fix this upstream then.

Yeah, I can do that

@kernelkind
Copy link
Member

I submitted a feature request:
emilk/egui#4490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants