You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Calling cytoscape.use(fcoseImport) silently does nothing, so calling the layout yields:
Uncaught Error: No such layout fcose found. Did you forget to import it and cytoscape.use() it?
Even the built-in layouts (e.g. { name: 'grid' }) work, but any custom or third-party layout (fcose, cola, grid-guide, expand-collapse, svg plugin) is unavailable.
Earlier in the upgrade process we also saw:
Uncaught SyntaxError: The requested module '…/dist/cytoscape.cjs.js' doesn't provide an export named: 'default'
reflecting the ESM/CJS entry-point changes in 3.29.0.
Desired behaviour
cytoscape-fcose, cytoscape-cola, cytoscape-grid-guide, cytoscape-expand-collapse and custom plugins (svg) should register and run correctly after upgrading to any 3.29.0+ release without special bundler workarounds.
The default ES module entrypoint (cytoscape/dist/cytoscape.esm.mjs) should export a true default and allow extensions to attach via cytoscape.use(...).
Minimum steps to reproduce
(You will need to go through the setup of Workload Discovery on AWS to reproduce).
git clone https://github.com/aws-solutions/workload-discovery-on-aws.git
cd workload-discovery-on-aws/source/frontend
In package.json, set
"dependencies": {
"cytoscape": "^3.29.0", // or higher up to 3.32.0"cytoscape-fcose": "^2.1.0",
"cytoscape-cola": "^3.3.0",
// …
}
npm install
npm run start
Open http://localhost:5173, navigate to Diagrams → Draw, and watch the browser console:
You’ll see fcoseImport: undefined
Then Uncaught Error: No such layout fcose found…
For reviewers
Reviewers should ensure that the following tasks are carried out for incorporated issues:
Ensure that the reporter has included a reproducible demo. They can easily fork this JSBin demo: http://jsbin.com/fiqugiq
The issue has been associated with a corresponding milestone.
The commits have been incorporated into the corresponding branches. Bug-fix patches go on
master and
unstable.
The issue has been labelled as a bug, if necessary.
The text was updated successfully, but these errors were encountered:
Environment info
Current (buggy) behaviour
After upgrading Cytoscape from v3.28.1 to any v3.29.0+ (up through v3.32.0), all third-party and custom extensions fail to register:
Plugin imports are
undefined
at runtime:Calling
cytoscape.use(fcoseImport)
silently does nothing, so calling the layout yields:Even the built-in layouts (e.g.
{ name: 'grid' }
) work, but any custom or third-party layout (fcose, cola, grid-guide, expand-collapse, svg plugin) is unavailable.Earlier in the upgrade process we also saw:
reflecting the ESM/CJS entry-point changes in 3.29.0.
Desired behaviour
cytoscape-fcose, cytoscape-cola, cytoscape-grid-guide, cytoscape-expand-collapse and custom plugins (svg) should register and run correctly after upgrading to any 3.29.0+ release without special bundler workarounds.
The standard pattern…
…should “just work” as it did in v3.28.1.
The default ES module entrypoint (
cytoscape/dist/cytoscape.esm.mjs
) should export a true default and allow extensions to attach viacytoscape.use(...)
.Minimum steps to reproduce
(You will need to go through the setup of Workload Discovery on AWS to reproduce).
git clone https://github.com/aws-solutions/workload-discovery-on-aws.git cd workload-discovery-on-aws/source/frontend
In
package.json
, setOpen http://localhost:5173, navigate to Diagrams → Draw, and watch the browser console:
fcoseImport: undefined
Uncaught Error: No such layout fcose found…
For reviewers
Reviewers should ensure that the following tasks are carried out for incorporated issues:
master
andunstable
.bug
, if necessary.The text was updated successfully, but these errors were encountered: