Skip to content

Commit e8ab563

Browse files
committed
address comments from code review [run ci]
1 parent 00de09a commit e8ab563

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

packages/server/lib/browsers/firefox.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ export async function open (browser: Browser, url: string, options: BrowserLaunc
463463

464464
const profileDir = utils.getProfileDir(browser, options.isTextTerminal)
465465

466-
// Delete the profile directory if in open mode.
466+
// Delete the legacy profile directory if in open mode.
467467
// Cypress does this because profiles are sourced and created differently with geckodriver/webdriver.
468468
// the profile creation method before 13.15.0 will no longer work with geckodriver/webdriver
469469
// and actually corrupts the profile directory from being able to be encoded. Hence, we delete it to prevent any conflicts.
@@ -513,9 +513,9 @@ export async function open (browser: Browser, url: string, options: BrowserLaunc
513513
// However, since Cypress 13.15.1,
514514
// geckodriver creates unique profile names that copy over the xulstore.json to the used profile.
515515
// The copy is ultimately updated on the unique profile name and is destroyed when the browser is torn down,
516-
// so the values are not persisted. Cypress could hypothetically determine the profile in use, copy the xulstore.json
516+
// so the values are not persisted. Cypress could hypothetically determine the profile is in use, copy the xulstore.json
517517
// out of the profile and try to persist it in the next created profile, but this method is likely error prone as it requires
518-
// moving/copying of files while creation/deletion of profiles occur, plus the ability to coorelate the correct profile to the current run,
518+
// moving/copying of files while creation/deletion of profiles occur, plus the ability to correlate the correct profile to the current run,
519519
// which there are not guarantees we can deterministically do this in open mode.
520520
const sizemode = 'maximized'
521521

@@ -592,7 +592,7 @@ export async function open (browser: Browser, url: string, options: BrowserLaunc
592592
browserInstanceWrapper.kill = () => undefined
593593

594594
try {
595-
/**
595+
/**
596596
* To set the profile, we use the profile capabilities in firefoxOptions which
597597
* requires the profile to be base64 encoded. The profile will be copied over to whatever
598598
* profile is created by geckodriver stemming from the root profile path.

0 commit comments

Comments
 (0)