Skip to content

ci: use node.js 22 in circleci mac job #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Situation

The CI pipeline .circleci/config.yml workflow mac-build runs in Node.js v20.13.1.

It should run in the Node.js version specified in .node-version, which is currently 22.

Change

  1. Update to executor [email protected]

  2. Use nvm to install Node.js 22 in the CI pipeline .circleci/config.yml workflow mac-build job mac-test

    This corresponds to the Node.js version stored in .node-version.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Collaborator Author

https://app.circleci.com/pipelines/github/cypress-io/cypress-example-kitchensink/2059/workflows/a4913b26-47ab-4fcf-80ac-64ce345104d2/jobs/14200 shows the mac-test job successfully running under Node.js v22.14.0

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        14.1.0                                                                         │
  │ Browser:        Electron 130 (headless)                                                        │
  │ Node Version:   v22.14.0 (/Users/distiller/.nvm/versions/node/v22.14.0/bin/node)               │
  │ Specs:          20 found (1-getting-started/todo.cy.js, 2-advanced-examples/actions.cy.js, 2-a │
  │                 dvanced-examples/aliasing.cy.js, 2-advanced-examples/assertions.cy.js, 2-advan │
  │                 ced-examples/connectors.cy.js, 2-advanced-examples/cookies.cy.js, 2-advanced-e │
  │                 xamples/cypress_api.cy....)                                                    │
  │ Searched:       cypress/e2e/**/*.cy.{js,jsx,ts,tsx}                                            │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 29, 2025 20:25
@jennifer-shehane jennifer-shehane merged commit 875b5dc into cypress-io:master Mar 31, 2025
12 checks passed
@MikeMcC399 MikeMcC399 deleted the circleci/macos-node-22 branch March 31, 2025 14:40
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 3.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Node.js version (v20.13.1) used in mac-build job mac-test
3 participants