Skip to content

ci: use node.js 22 in circleci windows jobs #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Situation

Currently the CI pipeline .circleci/config.yml workflow win-build runs using the default Node.js version v21.7.3 of the CircleCI [email protected].

Node.js version v21.7.3 is however no longer supported by Node.js, nor by Cypress. It reached its end-of-life milestone on June 1, 2024 already.

Change

  1. Update from [email protected] to [email protected]. This is a minor housekeeping update only, that should have no impact.
  2. In each of the jobs in the CI pipeline .circleci/config.yml workflow win-build use nvm to install Node.js 22 corresponding to the Node.js version stored in .node-version.

Verify

Review the logs of https://app.circleci.com/pipelines/github/cypress-io/cypress-example-kitchensink workflow win-build and confirm that in each job

  • win-test
  • win-test-chrome
  • win-test-firefox
  1. the "npm ci" step shows no npm WARN EBADENGINE Unsupported engine warning
  2. the "Run Cypress tests" logs Cypress running under Node.js v22.14.0

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 29, 2025 19:44
@jennifer-shehane jennifer-shehane merged commit 1362fed into cypress-io:master Mar 31, 2025
12 checks passed
@MikeMcC399 MikeMcC399 deleted the circleci/windows-node-22 branch March 31, 2025 14:39
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 3.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EBADENGINE in CircleCI win-build jobs
3 participants