fixed comments

Author: Andrey Zhavoronkov

cvat-core/src/server-proxy.js

@@ -159,7 +159,7 @@
                 const { backendAPI } = config;
                 let response = null;
                 try {
-                    response = await Axios.get(`${backendAPI}/restrictions/user_agreements`, {
+                    response = await Axios.get(`${backendAPI}/restrictions/user-agreements`, {
                         proxy: config.proxy,
                     });
 

cvat/apps/authentication/auth.py

@@ -116,7 +116,7 @@ def is_job_annotator(db_user, db_job):
     db_task = db_job.segment.task
     # A job can be annotated by any user if the task's assignee is None.
     has_rights = (db_task.assignee is None and not settings.RESTRICTIONS['reduce_task_visibility']) or is_task_assignee(db_user, db_task)
-    if db_job.assignee is not None and not settings.RESTRICTIONS['reduce_task_visibility']:
+    if db_job.assignee is not None:
         has_rights |= (db_user == db_job.assignee)
 
     return has_rights

cvat/apps/authentication/auth_basic.py

@@ -3,20 +3,13 @@
 # SPDX-License-Identifier: MIT
 from . import AUTH_ROLE
 from django.conf import settings
-from importlib import import_module
-
-def _import_role(role):
-    assert isinstance(role, str)
-    package, role_name = role.rsplit('.AUTH_ROLE.', 1)
-    module = getattr(import_module(package), 'AUTH_ROLE')
-    return getattr(module, role_name)
 
 def create_user(sender, instance, created, **kwargs):
     from django.contrib.auth.models import Group
 
     if instance.is_superuser and instance.is_staff:
         db_group = Group.objects.get(name=AUTH_ROLE.ADMIN)
         instance.groups.add(db_group)
-    for group in settings.DJANGO_AUTH_DEFAULT_GROUPS:
-        db_group = Group.objects.get(name=_import_role(group))
-        instance.groups.add(db_group)
+    for group_name in settings.DJANGO_AUTH_DEFAULT_GROUPS:
+        db_group = Group.objects.get(name=getattr(AUTH_ROLE, group_name))
+        instance.groups.add(db_group)

cvat/apps/restrictions/tests.py

@@ -37,7 +37,7 @@ def tearDown(self):
         settings.RESTRICTIONS['user_agreements'] = self.user_agreements
 
     def _get_user_agreements(self):
-        response = self.client.get('/api/v1/restrictions/user_agreements')
+        response = self.client.get('/api/v1/restrictions/user-agreements')
         assert response.status_code == status.HTTP_200_OK
         for agreements in response.data:
             assert 'name' in agreements, agreements['name']

cvat/apps/restrictions/views.py

@@ -27,14 +27,15 @@ def get_serializer(self, *args, **kwargs):
         method='get',
         operation_summary='Method provides user agreements that the user must accept to register',
         responses={'200': UserAgreementSerializer})
-    @action(detail=False, methods=['GET'], serializer_class=UserAgreementSerializer)
+    @action(detail=False, methods=['GET'], serializer_class=UserAgreementSerializer, url_path='user-agreements')
     def user_agreements(request):
         user_agreements = settings.RESTRICTIONS['user_agreements']
         serializer = UserAgreementSerializer(data=user_agreements, many=True)
         serializer.is_valid(raise_exception=True)
         return Response(data=serializer.data)
 
     @staticmethod
-    @action(detail=False, methods=['GET'], renderer_classes=(TemplateHTMLRenderer,))
+    @action(detail=False, methods=['GET'], renderer_classes=(TemplateHTMLRenderer,),
+        url_path='terms-of-use')
     def terms_of_use(request):
         return Response(template_name='restrictions/terms_of_use.html')