Skip to content

Commit 27e88fd

Browse files
committed
[CCK] Update compatibility with messages:12.3.2
Fixed in CI
1 parent 0bfbf34 commit 27e88fd

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

compatibility/src/test/java/io/cucumber/compatibility/matchers/AComparableMessage.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import java.util.Map;
1515
import java.util.stream.Collectors;
1616

17+
import static org.hamcrest.CoreMatchers.anyOf;
1718
import static org.hamcrest.CoreMatchers.is;
1819
import static org.hamcrest.CoreMatchers.isA;
1920
import static org.hamcrest.CoreMatchers.not;
@@ -90,7 +91,9 @@ private static List<Matcher<?>> extractExpectedFields(GeneratedMessageV3 expecte
9091
expected.add(hasEntry(is(fieldName), isA(expectedValue.getClass())));
9192
break;
9293
case "ci":
93-
expected.add(not(hasKey(is(fieldName))));
94+
// exception: Absent when running locally, present in ci
95+
expected.add(
96+
anyOf(not(hasKey(is(fieldName))), hasEntry(is(fieldName), isA(expectedValue.getClass()))));
9497
break;
9598
default:
9699
expected.add(hasEntry(is(fieldName), aComparableValue(expectedValue, depth)));

core/src/main/java/io/cucumber/core/runtime/CucumberExecutionContext.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@ public final class CucumberExecutionContext {
3333

3434
private static final String VERSION = ResourceBundle.getBundle("io.cucumber.core.version")
3535
.getString("cucumber-jvm.version");
36-
private static final String MESSAGE_PROTOCOL_VERSION = ResourceBundle.getBundle("io.cucumber.core.version")
37-
.getString("messages.version");
38-
3936
private static final Logger log = LoggerFactory.getLogger(CucumberExecutionContext.class);
4037

4138
private final EventBus bus;

0 commit comments

Comments
 (0)