Add some tests, tag your release and be more professional #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jmcollin78 opened this issue May 8, 2018 · 0 comments

Contributor

jmcollin78 commented May 8, 2018

I'm sorry to have to say that but this package is not in the state of the art:

no unit testing: bug AdmZip#toBuffer() leads to RangeError [ERR_INVALID_OPT_VALUE] #218 and 0.4.9 not extracting all folders #221 should not pass any basic simple unit tests,
your should tag your release: just use git tag -a -m 'comment' . It will be easier for contributor to see what have change and make diff between different release to see when a bug appears

With some of this simple things your package should be more usefull and contributors can go ahead withit.

cthackers closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment