chore(release): 4.0.0 #57
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
chore-release-4
branch
from
6ee4754 to
f36c33b
Compare
alexander-akait
commented
Sep 25, 2018
package.json
Outdated
| "description": "ICSS utils for postcss ast", | ||
| "main": "lib/index.js", | ||
| "files": [ | ||
| "lib" | ||
| "lib", | ||
| "src" |
There was a problem hiding this comment.
NEED REMOVE before release (require for tests and migration other plugins)
alexander-akait
force-pushed
the
chore-release-4
branch
from
f36c33b to
f3fdb6d
Compare
alexander-akait
commented
Sep 25, 2018
package.json
Outdated
| "description": "ICSS utils for postcss ast", | ||
| "main": "lib/index.js", | ||
| "main": "src/index.js", |
There was a problem hiding this comment.
NEED CHANGE before release (require for tests and migration other plugins)
alexander-akait
force-pushed
the
chore-release-4
branch
2 times, most recently
from
7852c54 to
f44e311
Compare
alexander-akait
commented
Sep 25, 2018
| @@ -1,3 +1,2 @@ | |||
| node_modules | |||
| coverage | |||
| lib | |||
There was a problem hiding this comment.
NEED RETURN before release (require for fast migration and testing)
alexander-akait
force-pushed
the
chore-release-4
branch
from
f44e311 to
a9c1dc0
Compare
alexander-akait
force-pushed
the
chore-release-4
branch
from
a9c1dc0 to
daa2719
Compare
|
@evilebottnawi hi, do you need help here? Looks like if we drop the node@4 support, we can also drop babel and remove the lib folder totally. |
|
@sullenor sorry, don't have time on this right now, feel free to do what you plan, I will fix the problems that I solved here later, they are not critical |
|
Close in favor #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54