Skip to content

Commit d927ad2

Browse files
committed
JCC feedback response -- modal title check (#763)
1 parent 68539bc commit d927ad2

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

webroot/src/components/Modal/Modal.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class Modal extends Vue {
5050
//
5151
get displayTitle(): string {
5252
if (this.title) {
53-
return this.title;
53+
return this.title.trim();
5454
}
5555

5656
return (this.isErrorModal) ? 'Error:' : 'Info:';

webroot/src/components/Modal/Modal.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
role="dialog"
2121
>
2222
<div class="header-container">
23-
<h1 v-if="title" class="modal-title">{{ displayTitle }}</h1>
23+
<h1 v-if="displayTitle" class="modal-title">{{ displayTitle }}</h1>
2424
<InputButton
2525
label="X"
2626
v-if="hasCloseIcon"

webroot/src/components/UpdateHomeJurisdiction/UpdateHomeJurisdiction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ class UpdateHomeJurisdiction extends mixins(MixinForm) {
154154
}
155155

156156
get jurisdictionModalTitle(): string {
157-
let title = '';
157+
let title = ' ';
158158

159159
if (this.isError) {
160160
title = this.$t('common.somethingWentWrong');

0 commit comments

Comments
 (0)