Skip to content

Commit 466f87f

Browse files
PR feedback cleanup
1 parent d1a7f47 commit 466f87f

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

backend/compact-connect/lambdas/python/migration/compact_configured_states_871/main.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ def do_migration(_properties: dict) -> None:
3737

3838
success_count = 0
3939
error_count = 0
40-
already_migrated_count = 0
4140

4241
for compact in compacts:
4342
try:
@@ -86,10 +85,7 @@ def do_migration(_properties: dict) -> None:
8685
error_count += 1
8786

8887
# Log final statistics
89-
logger.info(
90-
f'Migration completed: {success_count} compacts migrated successfully, '
91-
f'{already_migrated_count} compacts already migrated, {error_count} errors'
92-
)
88+
logger.info(f'Migration completed: {success_count} compacts migrated successfully, {error_count} errors')
9389

9490
if error_count > 0:
9591
raise RuntimeError(f'Compact configuredStates migration completed with {error_count} errors')

backend/compact-connect/tests/smoke/compact_configuration_smoke_tests.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import json
44

55
import requests
6+
from botocore.exceptions import ClientError
67
from config import config
78
from smoke_common import (
89
COMPACTS,
@@ -36,7 +37,7 @@ def cleanup_compact_configuration(compact: str):
3637
config.compact_configuration_dynamodb_table.delete_item(Key={'pk': pk, 'sk': sk})
3738
print(f'Cleaned up compact configuration for {compact}')
3839

39-
except Exception as e: # noqa: BLE001
40+
except ClientError as e:
4041
print(f'Warning: Error cleaning up compact configuration for {compact}: {e}')
4142

4243

@@ -56,7 +57,7 @@ def cleanup_jurisdiction_configuration(compact: str, jurisdiction: str):
5657
config.compact_configuration_dynamodb_table.delete_item(Key={'pk': pk, 'sk': sk})
5758
print(f'Cleaned up jurisdiction configuration for {jurisdiction} in {compact}')
5859

59-
except Exception as e: # noqa: BLE001
60+
except ClientError as e:
6061
print(f'Warning: Error cleaning up jurisdiction configuration for {jurisdiction} in {compact}: {e}')
6162

6263

0 commit comments

Comments
 (0)